Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eth_watchToken method to provider. #4112

Closed
danfinlay opened this issue Apr 27, 2018 · 1 comment
Closed

Add eth_watchToken method to provider. #4112

danfinlay opened this issue Apr 27, 2018 · 1 comment

Comments

@danfinlay
Copy link
Contributor

Would allow sites to suggest new tokens for the user to track in our token tracker:

ethereum/EIPs#747

Could maybe namespace under wallet_ or something, if we wanted to logically separate it from blockchain interactions.

Would allow users to easily add tokens to watch, with logos and everything, without us carrying the burden of verifying token projects and their logos.

Would require a new confirmation view "Do you want to add this token to your wallet?", along with the details of the token, including the current account's balance.

@danfinlay danfinlay added this to the Sprint 06 milestone Apr 27, 2018
@danfinlay danfinlay mentioned this issue Jun 18, 2018
3 tasks
@danfinlay danfinlay changed the title Add addToken method to provider. Add eth_watchToken method to provider. Jun 18, 2018
@danfinlay danfinlay added N05-needsSpec and removed needs-design Needs design support. labels Jun 18, 2018
@bdresser
Copy link
Contributor

closing - this was handled in #4606 @danfinlay ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants