Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make UI support right-to-left languages #5436

Closed
danfinlay opened this issue Oct 5, 2018 · 2 comments
Closed

Make UI support right-to-left languages #5436

danfinlay opened this issue Oct 5, 2018 · 2 comments

Comments

@danfinlay
Copy link
Contributor

What problem are you trying to solve?
Some languages, like Arabic (#3531), Hebrew, and Farsi (#5273) read from right to left. This affects not only text direction, but the general orientation of all UI elements: the side of a "back" arrow, the direction of that arrow, basically the whole UI would ideally be flipped vertically to support these languages.

Describe the solution you'd like
Ideally MetaMask auto-detects when a right-to-left language is selected, and orients its elements correctly, in an easily reusable way across the UI.

@brad-decker
Copy link
Contributor

#7072 -- believe this was resolved when this merged. @Gudahtt can you confirm and close issue if you agree?

@Gudahtt
Copy link
Member

Gudahtt commented Jul 27, 2020

I agree - this has been implemented, and should still work as far as I know.

I'm sure there are RTL mistakes here and there still, but we can open individual issues for any such mistakes we find.

@Gudahtt Gudahtt closed this as completed Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants