Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UX to show "unlimited" on Approve screen per EIP717 #6469

Closed
p-s-dev opened this issue Apr 17, 2019 · 3 comments
Closed

UX to show "unlimited" on Approve screen per EIP717 #6469

p-s-dev opened this issue Apr 17, 2019 · 3 comments

Comments

@p-s-dev
Copy link

p-s-dev commented Apr 17, 2019

What problem are you trying to solve?
User are confused when seeing "you grant permission for this contract to spend up to 1.158e+59 of your DAI"

Describe the solution you'd like
User would more easily understand "you grant permission for this contract to spend an unlimited amount of your DAI"

Additional context
if (approveAmount == uint(-1)) : UxMessage = "an unlimited amount"
@bdresser
Copy link
Contributor

@p-s-dev agree, the confirm screen for Approves can be pretty daunting, we'll be taking a look shortly.

@bdresser bdresser changed the title UX to show "unlimited" per EIP717 UX to show "unlimited" on Approve screen per EIP717 Apr 24, 2019
@RikaGoldberg
Copy link

Very excited for this change to be made. Will clear up a lot of confusion for users. Thanks.

@bdresser bdresser mentioned this issue Jul 8, 2019
Open
@Gudahtt
Copy link
Member

Gudahtt commented Dec 15, 2020

This was implemented in #7271

@Gudahtt Gudahtt closed this as completed Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bdresser @Gudahtt @p-s-dev @RikaGoldberg