Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use main-net ENS even when on other networks. #6916

Closed
danfinlay opened this issue Jul 25, 2019 · 2 comments
Closed

Use main-net ENS even when on other networks. #6916

danfinlay opened this issue Jul 25, 2019 · 2 comments

Comments

@danfinlay
Copy link
Contributor

The ropsten ENS deployment uses the .test suffix, and so using .ens is a safe way to fetch a recipient address, even when on another network, and so we should allow it.

Inspired by this comment on StackOverflow:
https://ethereum.stackexchange.com/questions/32804/can-metamask-read-ethereum-name-service-ens-addresses/32970?noredirect=1#comment88744_32970

@danfinlay
Copy link
Contributor Author

@wighawag we have opened an internal issue for tracking this, deleting comment to to prevent reduce spread of possible phishing strategies while we address the issue.

@Gudahtt
Copy link
Member

Gudahtt commented Jan 7, 2021

In #7944 we ensured that .eth addresses are only resolved on Mainnet. We could still add support for resolving them on Mainnet while another network is selected globally, but this is already tracked in #6708

I'll close this now, and we can track progress on the remaining work in #6708

@Gudahtt Gudahtt closed this as completed Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants