-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MetaMask action view should default to showing a connected account for the current tab #9020
Comments
I think I would like this behavior, so I'm all for it. Also, can we nail down naming? MetaMask Account Management Behaviors
|
I think that an api should be provided to get metamask current display account, so that the old DApp only needs to judge whether it needs to call "wallet_requestPermissions" based on the current display account. |
@tdvni agreed. See conversation here #8956 (comment) |
Just an update here, we have another design proposal that may solve this issue better than even this, and we're fleshing out that design a bit more before deciding whether or not this should be implemented before that larger change. |
What happened with this in the end? Is the workaround at #8990 (comment) still the way to go? Thanks. |
Inspired by the kind of confusion reported in issue #8956 and #8929
Problem
The Classic Suggestion
For long-time MetaMask users and developers, the obvious solution is to implement behavior that more closely resembles breaking the connection, so when user re-visits site A, they do not carry context from site B.
This can be achieved with a log-out button like #8990, or by recognizing when a user is returning with a non-enabled account selected, and acting "not logged in" in this context.
That issue was closed because of a decent workaround, but it doesn't change the case for old dapps that are not implementing this workaround, with old users who expect a single globally-selected account.
The Version 8 Native Solution
There is another approach that I think is better in the long run, and it goes back to the original V8 designs, and an improvement that we cut from the first v8 release for the sake of shipping it sooner:
When clicking the MetaMask fox, you should always see a view that is contextual to the current site you are viewing.
This may be a list of the connected accounts, but at the bare minimum, it should be a connected account.
This does not solve the problem of "users who expect a single globally connected account", which is our old behavior, and it's unfortunate that this means breaking an established expectation.
This does have a behavior that we believe is more intuitive to new users from web2, however: The MetaMask fox becomes like a login widget in the corner of any site, and it allows you to reference the account that is connected to that site.
We did not implement this behavior originally so that we could ship V8 a bit sooner, as it had some major changes that were otherwise blocking production, but now that it's out, this is a pretty clear improvement that was long part of the plan, so we just need to prioritize it appropriately.
The text was updated successfully, but these errors were encountered: