Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update Node.js to v20 #22755

Merged
merged 4 commits into from
Feb 1, 2024
Merged

chore: update Node.js to v20 #22755

merged 4 commits into from
Feb 1, 2024

Conversation

davidmurdoch
Copy link
Contributor

Description

Update Node.js to v20 (LTS)

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [f9aca80]
Page Load Metrics (770 ± 19 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint88140110147
domContentLoaded9261552
load7018637704019
domInteractive9261552
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c1a25ec) 68.31% compared to head (f9aca80) 68.31%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #22755   +/-   ##
========================================
  Coverage    68.31%   68.31%           
========================================
  Files         1088     1088           
  Lines        42812    42812           
  Branches     11390    11390           
========================================
  Hits         29243    29243           
  Misses       13569    13569           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HowardBraham HowardBraham merged commit eeeb939 into develop Feb 1, 2024
68 checks passed
@HowardBraham HowardBraham deleted the chore-update-node-to-v20 branch February 1, 2024 19:05
@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2024
@metamaskbot metamaskbot added the release-11.11.0 Issue or pull request that will be included in release 11.11.0 label Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.11.0 Issue or pull request that will be included in release 11.11.0 team-unkown
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants