fix: Enable wallet push notifications on restart

[Prithpal-Sooriya]

Description

This ensures that users who have enabled wallet notifications will receive push notifications when the application is starting up.

Related issues

Fixes: Bug when a user stops receiving push notifications if the service worker dies (e.g. browser is closed)

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [46bc896]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • content-script: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (629 ± 469 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	63	138	86	19	9
		domContentLoaded	9	35	13	6	3
		load	52	2384	629	977	469
		domInteractive	9	35	13	6	3

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 735 Bytes (0.02%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[danjm]

In the file above, there is a rename firebaseUnsubscribe -> pushListenerUnsubscribe. Here there is a rename unsubscribe -> unsubscribeFirebase. What is the difference between these two contexts that lead to the different names?

[Prithpal-Sooriya]

I agree - I will rename this to pushListenerUnsubscribe.

In this context, when listening to push notifications we need to listen to 2 things:

1. When a push notification is received (and how we need to handle it to show to users).
2. When a push notification is clicked.

Since we have 2 listeners, we need to make sure we unsubscribe from both if they need to be torn down.

[danjm]

Sort of indpendent of this PR, but a question came to me as I was reviewing: can users opt out of push notifications while still enabling the other notification functionality? Should they be able to?

[Prithpal-Sooriya]

@danjm

Sort of indpendent of this PR, but a question came to me as I was reviewing: can users opt out of push notifications while still enabling the other notification functionality? Should they be able to?

This was discussed somewhere in slack with our PM (see thread) - currently allowing notifications will also allow push notifications. I think we can in the future add more fine grain control (e.g. disable push notifications without disabling notifications).

[metamaskbot]

Builds ready [35cbb3b]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (667 ± 492 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	65	179	99	32	15
		domContentLoaded	9	49	14	9	4
		load	53	2560	667	1024	492
		domInteractive	9	49	13	9	4

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 293 Bytes (0.01%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[matteoscurati]

Go!

[codecov]

Codecov Report

Attention: Patch coverage is 28.57143% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 65.73%. Comparing base (70b2258) to head (12e2fb4).

Files	Patch %	Lines
...s/metamask-notifications/metamask-notifications.ts	44.44%	5 Missing ⚠️
...s/push-platform-notifications/services/services.ts	0.00%	4 Missing ⚠️
...tform-notifications/push-platform-notifications.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #24752      +/-   ##
===========================================
- Coverage    65.74%   65.73%   -0.00%     
===========================================
  Files         1366     1366              
  Lines        54227    54236       +9     
  Branches     14106    14108       +2     
===========================================
+ Hits         35648    35652       +4     
- Misses       18579    18584       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[metamaskbot]

Builds ready [12e2fb4]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (335 ± 371 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	65	175	94	24	11
		domContentLoaded	9	19	12	3	1
		load	53	2807	335	772	371
		domInteractive	9	19	12	3	1

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 293 Bytes (0.01%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)