fix: Add Basic Functionality to Settings Search

[darkwing]

Description

Adds "Basic Functionality" to the Settings search

Related issues

Fixes: #25441

Manual testing steps

1. Go to Settings
2. Search the term "Basic"
3. See "Basic Functionality" and click it
4. End up on top of the Privacy tab

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [2d5f289]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (211 ± 229 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	68	141	92	20	9
		domContentLoaded	8	25	13	5	2
		load	39	1735	211	476	229
		domInteractive	8	25	13	5	2

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 217 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[codecov]

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.17%. Comparing base (2455440) to head (efe5da8).
Report is 1 commits behind head on develop.

Files with missing lines	Patch %	Lines
ui/helpers/constants/settings.js	33.33%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #25185      +/-   ##
===========================================
- Coverage    70.17%   70.17%   -0.00%     
===========================================
  Files         1425     1425              
  Lines        49644    49647       +3     
  Branches     13889    13889              
===========================================
+ Hits         34835    34836       +1     
- Misses       14809    14811       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bergeron]

This PR did allow me to search + jump to the basic toggle. But I notice some other settings breaking. Looking for fix

Before on latest develop, IPFS gateway would jump correctly:

Screen.Recording.2024-06-10.at.12.44.23.PM.mov

But on this branch it jumps me to autodetect instead:

Screen.Recording.2024-06-10.at.12.45.48.PM.mov

[bergeron]

I think this is the fix. Just shifting the other indices that incremented (all except 18)

1dc663d

[sahar-fehri]

I've tested this, LGTM!

[salimtb]

Just tested it locally , LGTM

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[metamaskbot]

Builds ready [efe5da8]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1690 ± 115 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	271	2196	1588	356	171
		domContentLoaded	1429	2343	1671	243	117
		load	1432	2348	1690	240	115
		domInteractive	12	95	38	23	11

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 218 Bytes (0.00%)
• common: 0 Bytes (0.00%)