feat: new receive flow #26148

jonybur · 2024-07-26T02:33:51Z

Description

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2383

Manual testing steps

Got to the home menu
A "Portfolio" button should be on top of the main token display
Click on the "Receive" button
A QR code should pop up, showing the logo in the middle
A new copy address button should be present
The address of the account should be displayed (please check video underneath)

Screenshots/Recordings

demo.mp4

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-07-26T02:34:06Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

… jb-receive-flow

metamaskbot · 2024-08-21T14:49:02Z

Builds ready [57abcd1]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (84 ± 8 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	81	175	113	24	11
		domContentLoaded	41	112	81	20	9
		load	47	112	84	17	8
		domInteractive	10	57	30	10	5

Bundle size diffs [🚀 Bundle size reduced!]

background: 0 Bytes (0.00%)
ui: -2.34 KiB (-0.03%)
common: -8 Bytes (-0.00%)

ui/components/ui/qr-code-view/index.scss

georgewrmarshall · 2024-08-21T18:02:27Z

ui/components/ui/qr-code-view/index.scss

+  }
+
+  &__message {
+    @include design-system.H7;


I realize we need to add some stylelinting to deprecated these but the typography mixins have been deprecated in favor of the text component can we use it here instead?

Just removed &__message since it is unused

georgewrmarshall

Great use of component library components! Left some non-blocking comments.

NidhiKJha

LGTM! But it shouldn't conflict with the existing import account test?

NidhiKJha · 2024-08-21T18:10:20Z

test/e2e/tests/account/import-flow.spec.js

@@ -162,40 +161,6 @@ describe('Import flow @no-mmi', function () {
    );
  });

-  it('Import wallet using Secret Recovery Phrase with pasting word by word', async function () {


Why did we remove this test

Co-authored-by: George Marshall <george.marshall@consensys.net>

… jb-receive-flow

…ion into jb-receive-flow

Resolved, please re review

sonarcloud · 2024-08-21T22:20:06Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-08-21T22:54:58Z

Builds ready [36fc160]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (78 ± 7 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	69	142	103	20	9
		domContentLoaded	54	122	75	15	7
		load	56	122	78	15	7
		domInteractive	18	48	27	8	4

Bundle size diffs [🚀 Bundle size reduced!]

background: 0 Bytes (0.00%)
ui: -2.34 KiB (-0.03%)
common: -8 Bytes (-0.00%)

seaona · 2024-10-30T14:27:42Z

test/e2e/flask/btc/btc-account-overview.spec.ts

@@ -38,7 +38,7 @@ describe('BTC Account - Overview', function (this: Suite) {
        assert.equal(await buySellButton.isEnabled(), false);

        const portfolioButton = await driver.waitForSelector(
-          '[data-testid="coin-overview-portfolio"]',
+          '[data-testid="coin-overview-receive"]',


this spec is called has portfolio button enabled for BTC accounts however, here we are checking if the receive button is enabled (not the portfolio).
The portfolio link doesn't appear anymore. Is this expected? If so, the title for the test should be changed, otherwise we should open a bug, indicating that the portfolio link doesn't appear anymore

Good catch, PR to fix this:
#28184

jonybur added 2 commits July 26, 2024 03:11

New receive flow

906284f

Add inner logo

6be8c00

jonybur requested a review from a team as a code owner July 26, 2024 02:33

metamaskbot added the team-wallet-ux label Jul 26, 2024

jonybur marked this pull request as draft July 26, 2024 02:40

jonybur added 21 commits August 13, 2024 14:33

Merge branch 'develop' of github.com:MetaMask/metamask-extension into…

8a21ffc

… jb-receive-flow

Update snapshots

7c83dc7

Add data test id

15ddce1

Merge branch 'develop' of github.com:MetaMask/metamask-extension into…

f4cfdbd

… jb-receive-flow

Update mock state

aa2bcd3

Remove unused test

c67492a

Remove unused test

8df02d2

Remove test

afbf1a7

Remove test

ec0535c

Lint

e70e745

Merge branch 'develop' of github.com:MetaMask/metamask-extension into…

86dd4bb

… jb-receive-flow

Fix test

dd2f20e

Remove unused import

ba0dbc3

Update snapshot

fde5c94

Fix import-flow

faf2a02

Remove unused string

3763e6e

Revert changes

cdaae30

Fix tests

a9dfed9

Update match

f025cae

Fix selector

e65b814

Update address

d57a519

jonybur marked this pull request as ready for review August 14, 2024 23:49

jonybur added 2 commits August 15, 2024 01:07

Fix incremental-security

2ef88c7

Limit public address size

14d7915

jonybur requested review from mirceanis and NidhiKJha August 21, 2024 14:27

vinnyhoward previously approved these changes Aug 21, 2024

View reviewed changes

georgewrmarshall reviewed Aug 21, 2024

View reviewed changes

ui/components/ui/qr-code-view/index.scss Outdated Show resolved Hide resolved

georgewrmarshall reviewed Aug 21, 2024

View reviewed changes

ui/components/ui/qr-code-view/index.scss Outdated Show resolved Hide resolved

georgewrmarshall reviewed Aug 21, 2024

View reviewed changes

NidhiKJha previously requested changes Aug 21, 2024

View reviewed changes

Readd test

e0bdf44

jonybur dismissed vinnyhoward’s stale review via e0bdf44 August 21, 2024 22:05

jonybur and others added 5 commits August 21, 2024 23:05

Update ui/components/ui/qr-code-view/index.scss

5ea0a07

Co-authored-by: George Marshall <george.marshall@consensys.net>

Update ui/components/ui/qr-code-view/index.scss

0858533

Co-authored-by: George Marshall <george.marshall@consensys.net>

Merge branch 'develop' of github.com:MetaMask/metamask-extension into…

75a7eae

… jb-receive-flow

Remove unused CSS class

3147f14

Merge branch 'jb-receive-flow' of github.com:MetaMask/metamask-extens…

f1393da

…ion into jb-receive-flow

jonybur requested a review from NidhiKJha August 21, 2024 22:11

Fix lint

36fc160

NidhiKJha approved these changes Aug 22, 2024

View reviewed changes

salimtb approved these changes Aug 22, 2024

View reviewed changes

jonybur merged commit 82eb13e into develop Aug 22, 2024
78 checks passed

jonybur deleted the jb-receive-flow branch August 22, 2024 11:46

github-actions bot locked and limited conversation to collaborators Aug 22, 2024

metamaskbot added the release-12.5.0 Issue or pull request that will be included in release 12.5.0 label Aug 22, 2024

gauthierpetetin added release-12.4.0 Issue or pull request that will be included in release 12.4.0 and removed release-12.5.0 Issue or pull request that will be included in release 12.5.0 labels Sep 11, 2024

seaona reviewed Oct 30, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: new receive flow #26148

feat: new receive flow #26148

jonybur commented Jul 26, 2024 •

edited

Loading

github-actions bot commented Jul 26, 2024

metamaskbot commented Aug 21, 2024

georgewrmarshall Aug 21, 2024

jonybur Aug 21, 2024

georgewrmarshall left a comment

NidhiKJha left a comment

NidhiKJha Aug 21, 2024

sonarcloud bot commented Aug 21, 2024

metamaskbot commented Aug 21, 2024

seaona Oct 30, 2024

jonybur Oct 30, 2024

feat: new receive flow #26148

feat: new receive flow #26148

Conversation

jonybur commented Jul 26, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Jul 26, 2024

metamaskbot commented Aug 21, 2024

georgewrmarshall Aug 21, 2024

Choose a reason for hiding this comment

jonybur Aug 21, 2024

Choose a reason for hiding this comment

georgewrmarshall left a comment

Choose a reason for hiding this comment

NidhiKJha left a comment

Choose a reason for hiding this comment

NidhiKJha Aug 21, 2024

Choose a reason for hiding this comment

sonarcloud bot commented Aug 21, 2024

Quality Gate passed

metamaskbot commented Aug 21, 2024

seaona Oct 30, 2024

Choose a reason for hiding this comment

jonybur Oct 30, 2024

Choose a reason for hiding this comment

jonybur commented Jul 26, 2024 •

edited

Loading