fix (cherry-pick for v12.0.0): add unlock checks for notification related controllers

[Prithpal-Sooriya]

Description

This is a cherry pick for #26189 (2197d29)

Ensures that we correctly call the preinstalled snap when the wallet is unlocked. Also prevents unlock confirmations being created due to snap calls when wallet is locked

Related issues

Ticket

Fixes: #26064

Manual testing steps

1. Install the extension > go through onboarding > enable notifications
2. Restart browser or refresh the chrome extension
3. You should not see the unlock window pop up immediately and also stops the confirmation counter on the badge from continuously increasing due to preinstalled snap invokations.

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[codecov]

Codecov Report

Attention: Patch coverage is 74.41860% with 11 lines in your changes missing coverage. Please review.

Project coverage is 65.59%. Comparing base (6180c91) to head (309132e).

Files	Patch %	Lines
...s/metamask-notifications/metamask-notifications.ts	70.59%	5 Missing ⚠️
...ollers/authentication/authentication-controller.ts	71.43%	4 Missing ⚠️
...ontrollers/user-storage/user-storage-controller.ts	83.33%	2 Missing ⚠️

Additional details and impacted files

@@                 Coverage Diff                 @@
##           Version-v12.0.0   #26194      +/-   ##
===================================================
+ Coverage            65.58%   65.59%   +0.02%     
===================================================
  Files                 1368     1368              
  Lines                54566    54603      +37     
  Branches             14186    14180       -6     
===================================================
+ Hits                 35783    35816      +33     
- Misses               18783    18787       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[metamaskbot]

Builds ready [309132e]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (120 ± 150 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	71	190	87	25	12
		domContentLoaded	8	21	10	3	1
		load	41	1479	120	312	150
		domInteractive	8	21	10	3	1

[chloeYue]

hi @Prithpal-Sooriya , i don't see these 2 lines in this cherry-pick PR, is it intended?

export type Events =
  | MetamaskNotificationsControllerNotificationsListUpdatedEvent
  | MetamaskNotificationsControllerMarkNotificationsAsRead;

https://github.com/MetaMask/metamask-extension/pull/26189/files#diff-06756f69e37f2232f17817021fec595c4a1477c7ab9dc5ce90945c34801c00e0R216

[Prithpal-Sooriya]

Hey @chloeYue, yes these are recent changes only available in v12.0.1+, not in v12.0.0