diff --git a/ui/pages/notification-details/notification-details-footer/notification-details-footer.tsx b/ui/pages/notification-details/notification-details-footer/notification-details-footer.tsx index 2af87b2d6730..7a1f9a1c8890 100644 --- a/ui/pages/notification-details/notification-details-footer/notification-details-footer.tsx +++ b/ui/pages/notification-details/notification-details-footer/notification-details-footer.tsx @@ -35,9 +35,15 @@ export const NotificationDetailsFooter = ({ )} {footer.type === 'footer_feature_announcement' && ( - <> + + - + )} ); diff --git a/ui/pages/notifications/notification-components/feature-announcement/feature-announcement.tsx b/ui/pages/notifications/notification-components/feature-announcement/feature-announcement.tsx index 281112b6172d..d64015d590a3 100644 --- a/ui/pages/notifications/notification-components/feature-announcement/feature-announcement.tsx +++ b/ui/pages/notifications/notification-components/feature-announcement/feature-announcement.tsx @@ -114,6 +114,20 @@ export const components: NotificationComponent href={`/${notification.data.extensionLink.extensionLinkRoute}`} id={notification.id} endIconName={false} + // Even if the link is not external, it will open in a new tab + // to avoid breaking the popup + isExternal={true} + /> + ) : null, + ExternalLink: ({ notification }) => + notification.data.externalLink ? ( + ) : null, diff --git a/ui/pages/notifications/notification-components/types/notifications/notifications.ts b/ui/pages/notifications/notification-components/types/notifications/notifications.ts index 445646904ecb..15831627bf9c 100644 --- a/ui/pages/notifications/notification-components/types/notifications/notifications.ts +++ b/ui/pages/notifications/notification-components/types/notifications/notifications.ts @@ -40,6 +40,7 @@ type FooterOnChainNotification = { type FooterFeatureAnnouncement = { type: 'footer_feature_announcement'; ExtensionLink: NotificationFC; + ExternalLink: NotificationFC; }; /**