chore: MMI adds note to trader support to the new Tx confirmation view #27214
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [8bd8283]
Page Load Metrics (1753 ± 94 ms)
Bundle size diffs
|
|
Builds ready [28ebb05]
Page Load Metrics (1642 ± 111 ms)
Bundle size diffs
|
| labelText: string; | ||
| }; | ||
|
|
||
| const TabbedNoteToTrader: React.FC<NoteToTraderProps> = ({ |
There was a problem hiding this comment.
Will be removed towards the end of the year.
| <Text className="note-header__counter"> | ||
| {noteText.length}/{maxLength} | ||
| {noteText.length}/{280} |
There was a problem hiding this comment.
I'm not sure what's the intended behaviour with this, but do we want to do {noteText.length}/280 or {noteText.length}/{MAX_LENGTH} with const MAX_LENGTH = 280?
There was a problem hiding this comment.
the 280 is the max length. I'll assign it to a const in a next PR I have open 👍🏼
| return () => clearTimeout(timer); | ||
| }, [noteText]); | ||
|
|
||
| return isNoteToTraderSupported && !isSignature ? ( |
There was a problem hiding this comment.
[nit]: Can instead be expressed with an early return which is arguably more readable:
if (!isNotToTraderSupported || isSignature) {
return null
}| @@ -63,6 +64,11 @@ const Confirm = () => ( | |||
| <Title /> | |||
| <Info /> | |||
| <PluggableSection /> | |||
| { | |||
metamaskbot
added
release-12.6.0
|
Missing release label release-12.5.0 on PR. Adding release label release-12.5.0 on PR and removing other release labels(release-12.6.0), as PR was added to branch 12.5.0 when release was cut. |
Description
Adds the MMI transaction "note to trader" functionality to the new transactions redesign, the current one is also kept in order to facilitate backwards compatibility with the current confirmation view (to be removed later).
It also adds a few parameters that were missing for MMI like the tx metadata.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist