Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow state updates in Snaps interfaces to state values that are falsy #27488

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Sep 30, 2024

Description

Fixes a problem where state updates to Snaps interfaces would be ignored if the value was falsy, e.g. empty string.

Open in GitHub Codespaces

Screenshots/Recordings

Before

2024-09-30.12-37-41.mp4

After

2024-09-30.12-39-14.mp4

@FrederikBolding FrederikBolding added the team-snaps-platform Snaps Platform team label Sep 30, 2024
@FrederikBolding FrederikBolding requested a review from a team as a code owner September 30, 2024 09:54
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Sep 30, 2024
Copy link

sonarcloud bot commented Sep 30, 2024

@metamaskbot
Copy link
Collaborator

Builds ready [2ab2f28]
Page Load Metrics (1866 ± 171 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint33331361759476229
domContentLoaded144731171834353170
load145531511866356171
domInteractive13168463216
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 89 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@FrederikBolding FrederikBolding merged commit 8b35563 into develop Oct 1, 2024
88 checks passed
@FrederikBolding FrederikBolding deleted the fb/fix-state-updates-to-empty-string branch October 1, 2024 09:05
@github-actions github-actions bot locked and limited conversation to collaborators Oct 1, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Oct 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants