Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Etherscan API keys #27611

Merged
merged 8 commits into from
Oct 7, 2024

Conversation

matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Oct 3, 2024

Description

Upgrade the TransactionController to:

  • Support Etherscan API keys when polling for incoming transactions.
  • Populate submitHistory to aid with debug and persist even when resetting the account.

Also adds the ETHERSCAN_API_KEY environment variable.

Open in GitHub Codespaces

Related issues

Manual testing steps

  1. Verify incoming transactions work on Mainnet and Sepolia with an API key set.
  2. Verify submitHistory is populated in state logs after creating transactions and retrying, on both Infura and custom networks.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@matthewwalsh0 matthewwalsh0 added the team-confirmations Push issues to confirmations team label Oct 3, 2024
@matthewwalsh0 matthewwalsh0 requested a review from a team as a code owner October 3, 2024 21:14
Copy link

socket-security bot commented Oct 3, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/transaction-controller@37.2.0 network 0 2.13 MB metamaskbot

🚮 Removed packages: npm/@metamask/transaction-controller@37.1.0

View full report↗︎

@metamaskbot
Copy link
Collaborator

Builds ready [2a32e08]
Page Load Metrics (2087 ± 141 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint30626241786631303
domContentLoaded171629272050297143
load177229382087294141
domInteractive27110572211
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 80 Bytes (0.00%)
  • ui: -70 Bytes (-0.00%)
  • common: 1.41 KiB (0.02%)

@metamaskbot
Copy link
Collaborator

Builds ready [202a77b]
Page Load Metrics (1785 ± 124 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint152824801782249119
domContentLoaded152124621762245118
load152725431785258124
domInteractive268248199
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 80 Bytes (0.00%)
  • ui: -70 Bytes (-0.00%)
  • common: 1.41 KiB (0.02%)

@sleepytanya
Copy link
Contributor

Incoming transactions on Ethereum Mainnet:

ethereumtHistory.mov

Incoming transactions on Sepolia:

Sepolia.mov

Sepolia state logs:

sepolia

Mainnet on Infura and blastapi:

mainnetInfuraBlast

BNB on bsc-dataseed and llamarpc:

bnbBScLlama

Polygon on Infura and llamarpc:

polygonInfuraLlama

OGPoyraz
OGPoyraz previously approved these changes Oct 7, 2024
Copy link

sonarcloud bot commented Oct 7, 2024

@matthewwalsh0 matthewwalsh0 added this pull request to the merge queue Oct 7, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [73c56ad]
Page Load Metrics (1754 ± 75 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint17521881675381183
domContentLoaded15402090172813766
load15442200175415675
domInteractive237138147
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 80 Bytes (0.00%)
  • ui: -70 Bytes (-0.00%)
  • common: 242 Bytes (0.00%)

Merged via the queue into develop with commit 60ae8cb Oct 7, 2024
77 checks passed
@matthewwalsh0 matthewwalsh0 deleted the feat/incoming-transaction-etherscan-api-keys branch October 7, 2024 15:03
@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2024
@metamaskbot metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 7, 2024
@gauthierpetetin gauthierpetetin added release-12.6.0 Issue or pull request that will be included in release 12.6.0 and removed release-12.7.0 Issue or pull request that will be included in release 12.7.0 labels Oct 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA Passed release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants