-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support Etherscan API keys #27611
Merged
matthewwalsh0
merged 8 commits into
develop
from
feat/incoming-transaction-etherscan-api-keys
Oct 7, 2024
Merged
feat: support Etherscan API keys #27611
matthewwalsh0
merged 8 commits into
develop
from
feat/incoming-transaction-etherscan-api-keys
Oct 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/transaction-controller@37.1.0 |
Remove duplicate data in UI state.
Builds ready [2a32e08]
Page Load Metrics (2087 ± 141 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [202a77b]
Page Load Metrics (1785 ± 124 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
OGPoyraz
previously approved these changes
Oct 7, 2024
Quality Gate passedIssues Measures |
jpuri
approved these changes
Oct 7, 2024
OGPoyraz
approved these changes
Oct 7, 2024
Builds ready [73c56ad]
Page Load Metrics (1754 ± 75 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
metamaskbot
added
the
release-12.7.0
Issue or pull request that will be included in release 12.7.0
label
Oct 7, 2024
gauthierpetetin
added
release-12.6.0
Issue or pull request that will be included in release 12.6.0
and removed
release-12.7.0
Issue or pull request that will be included in release 12.7.0
labels
Oct 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
QA Passed
release-12.6.0
Issue or pull request that will be included in release 12.6.0
team-confirmations
Push issues to confirmations team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade the
TransactionController
to:submitHistory
to aid with debug and persist even when resetting the account.Also adds the
ETHERSCAN_API_KEY
environment variable.Related issues
Manual testing steps
submitHistory
is populated in state logs after creating transactions and retrying, on both Infura and custom networks.Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist