fix: Limit amount of decimals on spending cap modal #27672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
matthewwalsh0
previously requested changes
Oct 7, 2024
| @@ -116,10 +128,17 @@ export const EditSpendingCapModal = ({ | |||
| setCustomSpendingCapInputValue(formattedSpendingCap.toString()); | |||
| }, [customSpendingCapInputValue, formattedSpendingCap]); | |||
|
|
|||
| const showDecimalError = useMemo(() => { | |||
There was a problem hiding this comment.
Minor, do we need a memo for this as some basic math will have negligible performance cost?
| return ( | ||
| <Modal | ||
| isOpen={isOpenEditSpendingCapModal} | ||
| onClose={() => setIsOpenEditSpendingCapModal(false)} | ||
| onClose={() => handleCancel()} |
There was a problem hiding this comment.
Minor, no need for the lambda since handleCancel is already a function reference with no arguments?
pedronfigueiredo
force-pushed
the
pnf/27618
branch
from
5039147
to
a62e734
Compare
Builds ready [a62e734]
Page Load Metrics (1832 ± 78 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
pedronfigueiredo
force-pushed
the
pnf/27618
branch
from
a62e734
to
4255182
Compare
Builds ready [4255182]
Page Load Metrics (1932 ± 124 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
OGPoyraz
reviewed
Oct 9, 2024
...ons/components/confirm/info/approve/edit-spending-cap-modal/edit-spending-cap-modal.test.tsx
Outdated
Show resolved
Hide resolved
jpuri
previously approved these changes
Oct 9, 2024
jpuri
reviewed
Oct 9, 2024
| const decimalDigits = numberString.length - decimalPointIndex - 1; | ||
|
|
||
| return decimalDigits; | ||
| } |
There was a problem hiding this comment.
return numberString.split(".")[1].length || 0;
pedronfigueiredo
force-pushed
the
pnf/27618
branch
2 times, most recently
from
264c806
to
1049573
Compare
OGPoyraz
approved these changes
Oct 9, 2024
pedronfigueiredo
force-pushed
the
pnf/27618
branch
from
1049573
to
0764d25
Compare
|
Builds ready [0764d25]
Page Load Metrics (1795 ± 53 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
jpuri
approved these changes
Oct 9, 2024
pedronfigueiredo
dismissed
matthewwalsh0’s stale review
comments were addressed
metamaskbot
added
the
release-12.7.0
gauthierpetetin
added
release-12.6.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the user tries to add more decimals to the spending cap than what the token supports, the spending cap cannot be submitted and a notice is displayed.
Related issues
Fixes: #27618
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist