chore(deps): bump `@metamask/eth-ledger-bridge-keyring` to `^5.0.1` #27688

mikesposito · 2024-10-08T08:05:46Z

Description

This PR bumps the @metamask/eth-ledger-bridge-keyring dependency to ^5.0.1.

Related issues

Unblocks: #26840

Manual testing steps

This changes directly impacts Ledger devices:

Add one or more ledger accounts
Sign message
Sign typed data
Sign transaction
Remove Ledger accounts

Screenshots/Recordings

Before

After

Add account and sign

Ledger_sign.mp4

Forget device

Ledger_forget.mp4

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

socket-security · 2024-10-08T08:06:52Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/eth-ledger-bridge-keyring@5.0.1	None	`0`	156 kB	metamaskbot
npm/follow-redirects@1.15.9	network	`0`	29.9 kB	rubenverborgh

🚮 Removed packages: npm/@metamask/eth-ledger-bridge-keyring@3.0.1, npm/follow-redirects@1.15.6

View full report↗︎

socket-security · 2024-10-08T08:06:54Z

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

mikesposito · 2024-10-08T19:51:21Z

@metamaskbot update-policies

metamaskbot · 2024-10-08T20:00:26Z

Policy update failed. You can review the logs or retry the policy update here

sonarcloud · 2024-10-09T12:28:11Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-10-09T12:51:44Z

Builds ready [4275009]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1994 ± 104 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	395	2618	1918	416	200
		domContentLoaded	1657	2559	1978	216	104
		load	1700	2565	1994	216	104
		domInteractive	29	81	50	19	9

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 1.48 MiB (37.81%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-11-06T12:20:58Z

Builds ready [292b707]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1926 ± 69 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	364	2313	1852	373	179
		domContentLoaded	1702	2264	1891	137	66
		load	1716	2311	1926	144	69
		domInteractive	28	101	52	22	10
		backgroundConnect	8	102	40	27	13
		firstReactRender	48	149	89	26	13
		getState	4	83	16	19	9
		initialActions	0	0	0	0	0
		loadScripts	1215	1605	1374	108	52
		setupStore	10	65	25	17	8
		uiStartup	1921	2502	2139	146	70

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 1.48 MiB (33.20%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-11-06T14:53:57Z

Builds ready [77d1ffa]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1828 ± 104 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	376	2595	1696	462	222
		domContentLoaded	1613	2308	1774	149	71
		load	1657	2678	1828	217	104
		domInteractive	27	270	62	51	24
		backgroundConnect	11	374	49	78	38
		firstReactRender	46	204	85	43	21
		getState	4	112	24	27	13
		initialActions	0	1	0	0	0
		loadScripts	1174	1672	1313	106	51
		setupStore	10	102	36	26	13
		uiStartup	1802	3199	2054	303	146

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 1.48 MiB (33.20%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

mikesposito · 2024-11-06T16:14:20Z

.yarn/patches/@ledgerhq-evm-tools-npm-1.2.3-414f44baa9.patch

This patch is needed because Lavamoat is unable to walk the dependency tree with subpath imports when the package ships esm and cjs versions

mikesposito · 2024-11-06T16:14:27Z

.yarn/patches/@ledgerhq-hw-app-eth-npm-6.39.0-866309bbbe.patch

This patch is needed because Lavamoat is unable to walk the dependency tree with subpath imports when the package ships esm and cjs versions

mikesposito · 2024-11-06T16:19:46Z

package.json

+    "@ledgerhq/cryptoassets-evm-signatures/axios": "^0.28.0",
+    "@ledgerhq/domain-service/axios": "^0.28.0",
+    "@ledgerhq/evm-tools/axios": "^0.28.0",
+    "@ledgerhq/hw-app-eth/axios": "^0.28.0",


Socket security advisory

metamaskbot · 2024-11-08T12:48:57Z

Builds ready [9de63e3]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1813 ± 59 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1585	2134	1827	133	64
		domContentLoaded	1569	2062	1784	116	56
		load	1583	2084	1813	123	59
		domInteractive	23	99	49	21	10
		backgroundConnect	13	92	36	23	11
		firstReactRender	55	307	114	64	31
		getState	6	67	20	20	9
		initialActions	0	1	0	0	0
		loadScripts	1133	1551	1318	107	51
		setupStore	5	49	12	12	6
		uiStartup	1774	2485	2069	183	88

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 1.48 MiB (33.20%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

mcmire

Looks good!

metamaskbot · 2024-11-11T12:03:18Z

Builds ready [fd893e5]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2064 ± 147 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	490	2763	1975	458	220
		domContentLoaded	1677	2748	2038	301	144
		load	1688	2757	2064	306	147
		domInteractive	25	222	72	53	25
		backgroundConnect	8	95	29	23	11
		firstReactRender	89	164	109	15	7
		getState	5	56	15	17	8
		initialActions	0	0	0	0	0
		loadScripts	1220	2164	1527	262	126
		setupStore	5	78	15	19	9
		uiStartup	1900	2975	2287	325	156

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 1.48 MiB (33.20%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

DDDDDanica · 2024-11-11T19:40:10Z

LGTM !

metamaskbot · 2024-11-12T12:43:03Z

Builds ready [ac579f8]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2259 ± 120 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	397	2785	2074	604	290
		domContentLoaded	1861	2738	2215	254	122
		load	1892	2783	2259	250	120
		domInteractive	28	171	63	32	15
		backgroundConnect	8	100	49	32	16
		firstReactRender	57	299	136	52	25
		getState	6	69	24	18	9
		initialActions	0	1	0	0	0
		loadScripts	1361	2145	1653	215	103
		setupStore	6	87	20	21	10
		uiStartup	2083	3080	2528	276	132

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 1.48 MiB (33.20%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

github-actions bot added the team-wallet-framework label Oct 8, 2024

mikesposito changed the title ~~chore: update ledger keyring~~ chore(deps): update ledger keyring to ^5.0.0 Oct 8, 2024

This comment was marked as outdated.

Sign in to view

mikesposito changed the title ~~chore(deps): update ledger keyring to ^5.0.0~~ chore(deps): update ledger keyring to ^5.0.1 Oct 8, 2024

dawnseeker8 mentioned this pull request Nov 6, 2024

feat: upgrade eth-ledger-bridge-keyring to version 4.1.0 #26364

Closed

7 tasks

mikesposito added 8 commits November 6, 2024 12:32

chore: update ledger keyring

c5ee1ad

bump to ^5.0.1

0b39a46

fix: patch @ledgerhq/* subpath imports

6c816db

fix: downgrade @ledgerhq/**/axios

57772fb

update policies

f63b2e9

dedupe packages

bf8c3b2

fix audit with axios@0.28.0

0baee7d

update policies

292b707

mikesposito force-pushed the mikesposito/update-ledger branch from 4275009 to 292b707 Compare November 6, 2024 11:45

Merge branch 'develop' into mikesposito/update-ledger

77d1ffa

mikesposito marked this pull request as ready for review November 6, 2024 16:08

mikesposito requested review from a team as code owners November 6, 2024 16:08

mikesposito requested a review from a team November 6, 2024 16:11

mikesposito changed the title ~~chore(deps): update ledger keyring to ^5.0.1~~ chore(deps): @metamask/eth-ledger-bridge-keyring to ^5.0.1 Nov 6, 2024

mikesposito changed the title ~~chore(deps): @metamask/eth-ledger-bridge-keyring to ^5.0.1~~ chore(deps): bump @metamask/eth-ledger-bridge-keyring to ^5.0.1 Nov 6, 2024

mikesposito commented Nov 6, 2024

View reviewed changes

Merge branch 'develop' into mikesposito/update-ledger

9de63e3

mcmire approved these changes Nov 8, 2024

View reviewed changes

Merge branch 'develop' into mikesposito/update-ledger

fd893e5

Merge branch 'develop' into mikesposito/update-ledger

ac579f8

cryptodev-2s approved these changes Nov 12, 2024

View reviewed changes

mikesposito added this pull request to the merge queue Nov 12, 2024

Merged via the queue into develop with commit 7b3f951 Nov 12, 2024
76 checks passed

mikesposito deleted the mikesposito/update-ledger branch November 12, 2024 23:55

github-actions bot locked and limited conversation to collaborators Nov 12, 2024

metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Nov 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(deps): bump `@metamask/eth-ledger-bridge-keyring` to `^5.0.1` #27688

chore(deps): bump `@metamask/eth-ledger-bridge-keyring` to `^5.0.1` #27688

mikesposito commented Oct 8, 2024 •

edited

Loading

socket-security bot commented Oct 8, 2024 •

edited

Loading

socket-security bot commented Oct 8, 2024 •

edited

Loading

This comment was marked as outdated.

This comment was marked as outdated.

mikesposito commented Oct 8, 2024

metamaskbot commented Oct 8, 2024

sonarcloud bot commented Oct 9, 2024

metamaskbot commented Oct 9, 2024

metamaskbot commented Nov 6, 2024

metamaskbot commented Nov 6, 2024

mikesposito Nov 6, 2024

mikesposito Nov 6, 2024

mikesposito Nov 6, 2024

metamaskbot commented Nov 8, 2024

mcmire left a comment

metamaskbot commented Nov 11, 2024

DDDDDanica commented Nov 11, 2024

metamaskbot commented Nov 12, 2024

chore(deps): bump @metamask/eth-ledger-bridge-keyring to ^5.0.1 #27688

chore(deps): bump @metamask/eth-ledger-bridge-keyring to ^5.0.1 #27688

Conversation

mikesposito commented Oct 8, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

socket-security bot commented Oct 8, 2024 • edited Loading

socket-security bot commented Oct 8, 2024 • edited Loading

This comment was marked as outdated.

This comment was marked as outdated.

mikesposito commented Oct 8, 2024

metamaskbot commented Oct 8, 2024

sonarcloud bot commented Oct 9, 2024

Quality Gate passed

metamaskbot commented Oct 9, 2024

metamaskbot commented Nov 6, 2024

metamaskbot commented Nov 6, 2024

mikesposito Nov 6, 2024

Choose a reason for hiding this comment

mikesposito Nov 6, 2024

Choose a reason for hiding this comment

mikesposito Nov 6, 2024

Choose a reason for hiding this comment

metamaskbot commented Nov 8, 2024

mcmire left a comment

Choose a reason for hiding this comment

metamaskbot commented Nov 11, 2024

DDDDDanica commented Nov 11, 2024

metamaskbot commented Nov 12, 2024

chore(deps): bump `@metamask/eth-ledger-bridge-keyring` to `^5.0.1` #27688

chore(deps): bump `@metamask/eth-ledger-bridge-keyring` to `^5.0.1` #27688

mikesposito commented Oct 8, 2024 •

edited

Loading

socket-security bot commented Oct 8, 2024 •

edited

Loading

socket-security bot commented Oct 8, 2024 •

edited

Loading