Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Create custom trace to measure performance of opening the account list #27907

Merged
merged 9 commits into from
Oct 18, 2024

Conversation

MajorLift
Copy link
Contributor

@MajorLift MajorLift commented Oct 16, 2024

Description

Open in GitHub Codespaces

Adds custom Sentry trace "Account List" that starts when the AccountPicker component is clicked, and ends when the AccountListMenu component has finished rendering.

  • Baseline performance:
Screenshot 2024-10-16 at 9 45 28 AM Screenshot 2024-10-16 at 9 45 40 AM

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@MajorLift MajorLift added area-Sentry error reporting to sentry area-performance Issues relating to slowness of app, cpu usage, and/or blank screens. team-tiger Tiger team (for tech debt reduction + performance improvements) labels Oct 16, 2024
@MajorLift MajorLift self-assigned this Oct 16, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@MajorLift MajorLift changed the title Create custom trace to measure performance of opening the account list perf: Create custom trace to measure performance of opening the account list Oct 16, 2024
@MajorLift MajorLift force-pushed the jongsun/perf/trace/241014-account-list branch from aecaa4c to 2f19f36 Compare October 16, 2024 14:25
@MajorLift MajorLift marked this pull request as ready for review October 16, 2024 14:26
@MajorLift MajorLift requested review from a team as code owners October 16, 2024 14:26
Copy link

sonarcloud bot commented Oct 16, 2024

@metamaskbot
Copy link
Collaborator

Builds ready [2f19f36]
Page Load Metrics (2017 ± 114 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint43826491913405195
domContentLoaded167925071975226109
load171826752017238114
domInteractive20111482110
backgroundConnect9164373818
firstReactRender532881215828
getState5102222713
initialActions01000
loadScripts12321940147720498
setupStore13110463215
uiStartup188836942322391188
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 357 Bytes (0.00%)
  • common: 29 Bytes (0.00%)

@gauthierpetetin
Copy link
Contributor

TODO: Add alerts once this PR is merged and deployed in production

@HowardBraham HowardBraham added this pull request to the merge queue Oct 18, 2024
Merged via the queue into develop with commit e8bc6a5 Oct 18, 2024
78 checks passed
@HowardBraham HowardBraham deleted the jongsun/perf/trace/241014-account-list branch October 18, 2024 17:44
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2024
@metamaskbot metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Oct 18, 2024
@gauthierpetetin gauthierpetetin added release-12.6.0 Issue or pull request that will be included in release 12.6.0 and removed release-12.8.0 Issue or pull request that will be included in release 12.8.0 labels Oct 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-performance Issues relating to slowness of app, cpu usage, and/or blank screens. area-Sentry error reporting to sentry release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-tiger Tiger team (for tech debt reduction + performance improvements) team-wallet-framework
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants