-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: Create custom trace to measure performance of opening the account list #27907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MajorLift
added
area-Sentry
error reporting to sentry
area-performance
Issues relating to slowness of app, cpu usage, and/or blank screens.
team-tiger
Tiger team (for tech debt reduction + performance improvements)
labels
Oct 16, 2024
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
MajorLift
changed the title
Create custom trace to measure performance of opening the account list
perf: Create custom trace to measure performance of opening the account list
Oct 16, 2024
MajorLift
force-pushed
the
jongsun/perf/trace/241014-account-list
branch
from
October 16, 2024 14:25
aecaa4c
to
2f19f36
Compare
Quality Gate passedIssues Measures |
Builds ready [2f19f36]
Page Load Metrics (2017 ± 114 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
TODO: Add alerts once this PR is merged and deployed in production |
HowardBraham
approved these changes
Oct 18, 2024
darkwing
approved these changes
Oct 18, 2024
vinnyhoward
approved these changes
Oct 18, 2024
metamaskbot
added
the
release-12.8.0
Issue or pull request that will be included in release 12.8.0
label
Oct 18, 2024
gauthierpetetin
added
release-12.6.0
Issue or pull request that will be included in release 12.6.0
and removed
release-12.8.0
Issue or pull request that will be included in release 12.8.0
labels
Oct 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-performance
Issues relating to slowness of app, cpu usage, and/or blank screens.
area-Sentry
error reporting to sentry
release-12.6.0
Issue or pull request that will be included in release 12.6.0
team-tiger
Tiger team (for tech debt reduction + performance improvements)
team-wallet-framework
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds custom Sentry trace "
Account List
" that starts when theAccountPicker
component is clicked, and ends when theAccountListMenu
component has finished rendering.Related issues
Manual testing steps
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist