-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: storybook getManifest
issue
#28010
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
lavamoat did not like the esm syntax for this file
Prithpal-Sooriya
force-pushed
the
fix/storybook-get-manifest-issue
branch
from
October 22, 2024 15:46
ccf422c
to
d298fa7
Compare
matteoscurati
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Builds ready [e045737]
Page Load Metrics (1980 ± 54 ms)
Bundle size diffs
|
itsyoboieltr
approved these changes
Oct 22, 2024
mathieuartu
approved these changes
Oct 23, 2024
Builds ready [c955f33]
Page Load Metrics (2086 ± 187 ms)
Bundle size diffs
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 23, 2024
metamaskbot
added
the
release-12.7.0
Issue or pull request that will be included in release 12.7.0
label
Oct 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-12.7.0
Issue or pull request that will be included in release 12.7.0
team-notifications
Notifications team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This issue was unintentionally brought in through this commit.
e8bc6a5
shared/lib/trace.ts
app/scripts/lib/setupSentry.js
shared/modules/mv3.utils.js
global.chrome?.runtime.getManifest()
orglobal.browser?.runtime.getManifest()
.Storybook leverages the
webextension-polyfill
as part of it's webpack build configuration. We can use this to polyfill theglobal.chrome.runtime
for storybook mocks.Related issues
Fixes:
Manual testing steps
Run storybook locally, are you able to visit the multichain account list menu storybook?
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist