Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: storybook getManifest issue #28010

Merged
merged 6 commits into from
Oct 23, 2024

Conversation

Prithpal-Sooriya
Copy link
Contributor

@Prithpal-Sooriya Prithpal-Sooriya commented Oct 22, 2024

Description

This issue was unintentionally brought in through this commit.

e8bc6a5

  • This commit uses shared/lib/trace.ts
  • Which in turn uses app/scripts/lib/setupSentry.js
  • Which in turn uses shared/modules/mv3.utils.js
  • Which is unable to resolve global.chrome?.runtime.getManifest() or global.browser?.runtime.getManifest().

Storybook leverages the webextension-polyfill as part of it's webpack build configuration. We can use this to polyfill the global.chrome.runtime for storybook mocks.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

Run storybook locally, are you able to visit the multichain account list menu storybook?

Screenshots/Recordings

Before

Screenshot 2024-10-22 at 16 09 08

After

Screenshot 2024-10-22 at 16 16 14

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-notifications Notifications team label Oct 22, 2024
lavamoat did not like the esm syntax for this file
@Prithpal-Sooriya Prithpal-Sooriya force-pushed the fix/storybook-get-manifest-issue branch from ccf422c to d298fa7 Compare October 22, 2024 15:46
@Prithpal-Sooriya Prithpal-Sooriya marked this pull request as ready for review October 22, 2024 17:07
@Prithpal-Sooriya Prithpal-Sooriya requested a review from a team as a code owner October 22, 2024 17:07
Copy link
Contributor

@matteoscurati matteoscurati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metamaskbot
Copy link
Collaborator

Builds ready [e045737]
Page Load Metrics (1980 ± 54 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint30322161755584281
domContentLoaded17912181195210550
load17992223198011354
domInteractive28231685426
backgroundConnect983352412
firstReactRender5111795168
getState476242512
initialActions01000
loadScripts1293167114529445
setupStore117124189
uiStartup20032467219413163
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@Prithpal-Sooriya Prithpal-Sooriya added this pull request to the merge queue Oct 23, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [c955f33]
Page Load Metrics (2086 ± 187 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint41137822009540259
domContentLoaded176737122057393189
load178037252086389187
domInteractive1984462010
backgroundConnect982262311
firstReactRender543031357134
getState575292612
initialActions01000
loadScripts128731561548379182
setupStore1194292612
uiStartup199839642380423203
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 23, 2024
@Prithpal-Sooriya Prithpal-Sooriya added this pull request to the merge queue Oct 23, 2024
Merged via the queue into develop with commit eb5b2b2 Oct 23, 2024
76 checks passed
@Prithpal-Sooriya Prithpal-Sooriya deleted the fix/storybook-get-manifest-issue branch October 23, 2024 10:23
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2024
@metamaskbot metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.7.0 Issue or pull request that will be included in release 12.7.0 team-notifications Notifications team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants