Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: e2e quality gate enhancement #28206

Merged
merged 3 commits into from
Nov 6, 2024
Merged

chore: e2e quality gate enhancement #28206

merged 3 commits into from
Nov 6, 2024

Conversation

seaona
Copy link
Contributor

@seaona seaona commented Oct 31, 2024

Description

With the label:

Screenshot from 2024-10-31 12-02-14

When removing the label:

Screenshot from 2024-10-31 12-11-56

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. See here, were we skip the git diff as it had the label https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/108789/workflows/01710cd9-1a1b-4c47-8f66-3796d57ea732/jobs/4069000

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@seaona seaona self-assigned this Oct 31, 2024
@seaona seaona changed the title chore: skip quality e2e chore: e2e quality gate enhancement Oct 31, 2024
@seaona seaona marked this pull request as ready for review October 31, 2024 11:05
@seaona seaona requested review from kumavis and a team as code owners October 31, 2024 11:05
@metamaskbot
Copy link
Collaborator

Builds ready [33b2cec]
Page Load Metrics (1777 ± 54 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15641996177711354
domContentLoaded15541980175210349
load15641994177711354
domInteractive23186653919
backgroundConnect98324199
firstReactRender45215893818
getState463172010
initialActions01000
loadScripts1128145612998239
setupStore1179402412
uiStartup18152249200811053
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@seaona seaona added the area-qa Relating to QA work (Quality Assurance) label Oct 31, 2024
Copy link
Contributor

@chloeYue chloeYue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@hjetpoluru hjetpoluru self-requested a review October 31, 2024 16:28
Copy link
Contributor

@hjetpoluru hjetpoluru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@seaona seaona added this pull request to the merge queue Nov 6, 2024
Merged via the queue into develop with commit 10102d0 Nov 6, 2024
81 checks passed
@seaona seaona deleted the chore-skip-quality-e2e branch November 6, 2024 13:57
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2024
@metamaskbot metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Nov 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-qa Relating to QA work (Quality Assurance) release-12.8.0 Issue or pull request that will be included in release 12.8.0 team-extension-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants