-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: notification settings type #28271
Merged
Prithpal-Sooriya
merged 1 commit into
develop
from
types/fix-notification-settings-types
Nov 4, 2024
Merged
fix: notification settings type #28271
Prithpal-Sooriya
merged 1 commit into
develop
from
types/fix-notification-settings-types
Nov 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Prithpal-Sooriya
changed the title
fix: fix notification settings type
fix: notification settings type
Nov 4, 2024
dovydas55
approved these changes
Nov 4, 2024
Prithpal-Sooriya
commented
Nov 4, 2024
matteoscurati
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Builds ready [2e5c4c3]
Page Load Metrics (1790 ± 97 ms)
Bundle size diffs
|
metamaskbot
added
the
release-12.8.0
Issue or pull request that will be included in release 12.8.0
label
Nov 4, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-12.8.0
Issue or pull request that will be included in release 12.8.0
team-notifications
Notifications team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes a poor type from converting a selectors file from JS to TS.
Instead of using a custom type for the accounts type, we can just use inferred types.
Related issues
Fixes: #27645 (comment)
Manual testing steps
N/A these are only type level changes
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist