Resubmit fix #6888
Merged
Resubmit fix #6888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danfinlay
requested review from
danjm,
frankiebee,
Gudahtt and
whymarrh
as code owners
frankiebee
approved these changes
Jul 19, 2019
Gudahtt
approved these changes
Jul 19, 2019
There was a problem hiding this comment.
LGTM
The audit failure is because one of our dependencies was unpublished since the last release. While this is of course something we should fix, it's not as urgent as this hotfix, and it doesn't indicate anything has gotten worse. I don't think it should block merging this PR.
tmashuang
approved these changes
Jul 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hotfix (merge to master) version of #6886.