Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Received transactions #6996

Merged
merged 15 commits into from
Aug 16, 2019
Merged

Received transactions #6996

merged 15 commits into from
Aug 16, 2019

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Aug 12, 2019 •
edited
Loading

Resolves #133

This PR adds the incoming transactions feature.

Demo video: https://streamable.com/4y6k4

To dos:

  • design review/QA
  • order the list of incoming txs by received time from most recently received to oldest
  • tests

e2e tests to come in future PR

@danjm danjm requested review from Gudahtt and whymarrh as code owners August 12, 2019 13:01
@metamaskbot
Copy link
Collaborator

Builds ready [88e43c9]: chrome, firefox, edge, opera

@danjm danjm force-pushed the i133-show-received-transactions branch 2 times, most recently from 7a7b5b8 to e7ae844 Compare August 15, 2019 15:52
@metamaskbot
Copy link
Collaborator

Builds ready [8cb86cf]: chrome, firefox, edge, opera

@metamaskbot
Copy link
Collaborator

Builds ready [7837f56]: chrome, firefox, edge, opera

danjm and others added 14 commits August 16, 2019 14:13
@danjm @whymarrh
Adds incoming transactions controller
fe8a0fe
@danjm @whymarrh
Adds UX for incoming transactions
2ebbedc
@danjm @whymarrh
Update fixture data for integration tests to accomodate incoming tx a…
b8c6a02 
…ddition
@danjm @whymarrh
Improve lastFetchBlockByCurrentNetwork logic in incoming-transactions…
efc7af1 
… controller
@danjm @whymarrh
Refactor incoming tx UX to only use the single tx list / tab
45a24a1
@danjm @whymarrh
Cleanup/refactor incoming-transactions.js
b87b992
@danjm @whymarrh
Add tests for the incoming transactions controller
7f7a19f
@danjm @whymarrh
Unit test fixes for received transactions
f56f369
@whymarrh
Remove unused received i18n message
6ce7f74
@whymarrh
Use return value from IncomingTransactionsController#_update in handlers
e84f6ba
@whymarrh
Rename incomingTxLastFetchedBlocksByNetwork
d0da125
@whymarrh
Use MAINNET enum in place of string literal
850c0cc
@whymarrh
Initialize latestIncomingTxBlockNumber in IncomingTransactionsController
aab817c
@whymarrh
Remove xtend usage from IncomingTransactionsController
076041d
@whymarrh whymarrh force-pushed the i133-show-received-transactions branch from 7837f56 to 076041d Compare August 16, 2019 17:11
@metamaskbot
Copy link
Collaborator

Builds ready [076041d]: chrome, firefox, edge, opera

@whymarrh whymarrh force-pushed the i133-show-received-transactions branch from b2524bc to a7eba59 Compare August 16, 2019 18:16
@metamaskbot
Copy link
Collaborator

Builds ready [a7eba59]: chrome, firefox, edge, opera

@metamaskbot
Copy link
Collaborator

Builds ready [a7eba59]: chrome, firefox, edge, opera

whymarrh
whymarrh approved these changes Aug 16, 2019
View reviewed changes
Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA'd and added a few commits, this LGTM

@whymarrh whymarrh merged commit 8215296 into develop Aug 16, 2019
@whymarrh whymarrh deleted the i133-show-received-transactions branch August 16, 2019 18:54
@whymarrh whymarrh mentioned this pull request Aug 20, 2019
Merged
@bbondy bbondy mentioned this pull request Dec 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whymarrh whymarrh whymarrh approved these changes

@Gudahtt Gudahtt Awaiting requested review from Gudahtt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show received transactions in transaction history
3 participants
@danjm @metamaskbot @whymarrh