Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add polyfill for AbortController #7157

Merged
merged 1 commit into from
Sep 12, 2019
Merged

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Sep 11, 2019

The AbortController is used in both the background and the UI. Support for AbortController was added to Chrome in version 66, which is above our minimum supported version.

I did consider increasing the minimum Chrome version to 66, but we have a decent number of users still on Chrome 65 unfortunately.

The AbortController is used in both the background and the UI. Support
for AbortController was added to Chrome in version 66, which is above
our minimum supported version.

I did consider increasing the minimum Chrome version to 66, but we have
a decent number of users still on Chrome 65 unfortunately.
@metamaskbot
Copy link
Collaborator

Builds ready [66cab16]

Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit, I looked through the polyfill and it looks like it will correctly short-circuit if the platform does support the AbortController

@Gudahtt Gudahtt merged commit 50e9c4e into develop Sep 12, 2019
@whymarrh whymarrh deleted the add-abort-controller-polyfill branch September 13, 2019 02:01
Gudahtt added a commit that referenced this pull request Sep 13, 2019
The AbortController is used in both the background and the UI. Support
for AbortController was added to Chrome in version 66, which is above
our minimum supported version.

I did consider increasing the minimum Chrome version to 66, but we have
a decent number of users still on Chrome 65 unfortunately.
Gudahtt added a commit that referenced this pull request Sep 17, 2019
…evelop

* origin/develop: (31 commits)
  Performance: Delivery optimized images (#7176)
  Add `appName` message to each locale
  Remove the disk store (#7170)
  Update @hapi/subtext as per security advisory (#7172)
  Add fixes for German translations (#7168)
  Fix recipient field of approve screen (#7171)
  3box integration 2.0 (#6972)
  ci - metamaskbot - include links to dep-viz and all artifacts (#7155)
  Replace `undefined` selectedAddress with `null` (#7161)
  Add polyfill for AbortController (#7157)
  Remove redundant error logging (#7158)
  Set minimum Firefox version to v56.2 to support Waterfox (#7156)
  ci - install deps with "--har" flag to capture network activity (#7143)
  ci - create source-map-explorer build-artifacts (#7141)
  ci - build-artifacts - generate sesify-viz for inspecting deps (#7151)
  Publish GitHub release from master branch (#7136)
  fix rinkeby spelling (#7148)
  deps - move gulp-terser-js to devDeps
  test:integration - fix renamed test data file
  lint fix
  ...
Gudahtt added a commit that referenced this pull request Sep 27, 2019
* origin/master:
  Add v7.2.2 to changelog
  Update minimum Firefox verison to 56.0 (#7213)
  Version v7.2.2
  Update changelog for v7.2.1, v7.2.0, and v7.1.1
  Add `appName` message to each locale
  Version v7.2.1
  Update changelog with additional bug fixes
  Fix recipient field of approve screen (#7171)
  Replace `undefined` selectedAddress with `null` (#7161)
  Add polyfill for AbortController (#7157)
  Set minimum Firefox version to v56.2 to support Waterfox (#7156)
  Publish GitHub release from master branch (#7136)
  Update the changelog for v7.1.1 (#7145)
  build - replace gulp-uglify-es with gulp-terser-js
  Version v7.2.0
  Update changelog with 7.2.0 changes
  Allow dismissing privacy mode from popup
  Add changelog
  Version v7.1.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants