Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add all icons to manifest #7431

Merged
merged 1 commit into from
Nov 15, 2019
Merged

Add all icons to manifest #7431

merged 1 commit into from
Nov 15, 2019

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Nov 14, 2019

Of the 7 different icon sizes we have, only four were referenced in the manifest. All 7 are now listed, which leaves the browser more to choose from when deciding which to use.

@Gudahtt
Add all icons to manfiest
3a9349e 
Of the 7 different icon sizes we have, only four were referenced in
the manifest. All 7 are now listed, which leaves the browser more to
choose from when deciding which to use.
@metamaskbot
Copy link
Collaborator

Builds ready [3a9349e]

tmashuang
tmashuang approved these changes Nov 15, 2019
View reviewed changes
Copy link
Contributor

@tmashuang tmashuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gudahtt Gudahtt changed the title Add all icons to manfiest Add all icons to manifest Nov 15, 2019
@Gudahtt Gudahtt merged commit 5e84c50 into develop Nov 15, 2019
@whymarrh whymarrh deleted the add-all-icons-to-manifest branch November 19, 2019 15:03
@bbondy bbondy mentioned this pull request Dec 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmashuang tmashuang tmashuang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gudahtt @metamaskbot @tmashuang