Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused onClick prop from Dropdown component #7500

Merged
merged 1 commit into from
Nov 22, 2019

Conversation

whymarrh
Copy link
Contributor

This PR fixes a warning that shows up during render:

Warning: Failed prop type: The prop `onClick` is marked as required in `Dropdown`, but its value is `undefined`.
    in Dropdown (created by NetworkDropdown)
    in NetworkDropdown (created by Connect(NetworkDropdown))
    in Connect(NetworkDropdown) (created by Route)
    in Route (created by withRouter(Connect(NetworkDropdown)))
    in withRouter(Connect(NetworkDropdown)) (created by Routes)
    in div (created by Routes)
    in Routes (created by Connect(Routes))
    in Connect(Routes) (created by Route)
    in Route (created by withRouter(Connect(Routes)))
    in withRouter(Connect(Routes)) (created by Index)
    in I18nProvider (created by Connect(I18nProvider))
    in Connect(I18nProvider) (created by Route)
    in Route (created by withRouter(Connect(I18nProvider)))
    in withRouter(Connect(I18nProvider)) (created by Index)
    in MetaMetricsProvider (created by Connect(MetaMetricsProvider))
    in Connect(MetaMetricsProvider) (created by Route)
    in Route (created by withRouter(Connect(MetaMetricsProvider)))
    in withRouter(Connect(MetaMetricsProvider)) (created by Index)
    in Router (created by HashRouter)
    in HashRouter (created by Index)
    in Provider (created by Index)
    in Index

@whymarrh
Copy link
Contributor Author

Turns Out™ this prop isn't used in the component

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@whymarrh whymarrh merged commit 5235d8d into MetaMask:develop Nov 22, 2019
@whymarrh whymarrh deleted the fix-prop-type branch November 22, 2019 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants