Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DETOX] Investigate Detox incompatibility with Android and @web3modal/ethers5 module #10024

Open
9 tasks
seaona opened this issue Jun 18, 2024 · 0 comments
Open
9 tasks

Comments

@seaona
Copy link
Contributor

seaona commented Jun 18, 2024

What is this about?

After adding Wallet Connect support in the test dapp (PR #284), we saw that Detox is no longer working whenever we are in an Android environment.

After invesigating, @vinistevam saw that the problem relies on importing the ethers package @web3modal/ethers5. Just using the import in the test-dapp, breaks the test environment when we navigate to the test dapp.
iOS works fine.
A workaround fix has been to use the import conditionally, depending on whether we are on an Android OS (PR #343), however we should investigate the root cause of this incompatibility.

Scenario

No response

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged

  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify)

References

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant