Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webrtc support #1513

Open
dpazdan opened this issue Apr 27, 2020 · 2 comments
Open

Add webrtc support #1513

dpazdan opened this issue Apr 27, 2020 · 2 comments
Assignees
Labels
browser Related to web browser functionality, e.g. HTTP CORS, bookmarking, etc. dapp-compatibility

Comments

@dpazdan
Copy link

dpazdan commented Apr 27, 2020

MetaMask browser is not compatible with Webrtc

If for example you open https://test.webrtc.org/ you can see that it doesn't work.

related to support ticket: 34641

@EtDu
Copy link
Contributor

EtDu commented Aug 31, 2020

Directly related #1042

@EtDu EtDu self-assigned this Aug 31, 2020
@EtDu EtDu added the browser Related to web browser functionality, e.g. HTTP CORS, bookmarking, etc. label Sep 2, 2020
@EtDu
Copy link
Contributor

EtDu commented Sep 2, 2020

@omnat Is this something we really want to add?

It seems to work in Android but we need to modify a few things to grant it the proper permissions.

For iOS, we'd have to implement the capability on the webview since it doesn't support it out of the box.

We could spend a long time trying to solve this problem, so I don't think it's worth our efforts.

Also check out #1042 because in a situation like this, we should inform them to use our soon to be wallet_scanQrCode RPC method
cc @andrepimenta cause you're working on the browser at the moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser Related to web browser functionality, e.g. HTTP CORS, bookmarking, etc. dapp-compatibility
Projects
None yet
Development

No branches or pull requests

4 participants