Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeError: undefined is not an object (evaluating 'f.balance') #2761

Closed
estebanmino opened this issue Jun 9, 2021 · 11 comments
Closed

TypeError: undefined is not an object (evaluating 'f.balance') #2761

estebanmino opened this issue Jun 9, 2021 · 11 comments
Assignees
@Cal-L
Labels
Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking type-bug Something isn't working

Comments

@estebanmino
Copy link
Contributor

estebanmino commented Jun 9, 2021 •
edited by Cal-L
Loading

Description

Error:

com.facebook.react.common.JavascriptException: TypeError: undefined is not an object (evaluating 'f.balance'), stack:
hasSufficientFunds@2989:6144
onGasLimitChange@2989:7492
onChange@342:2638

Technical Requirements

  • Handle undefined fromAccount.balance field. This is most likely caused by undefined fromAccount, so may need to dig into why that is undefined.
  • Properly handle/render condition where balance is undefined.
  • This issue lives in the CustomGas index.js file

Acceptance Criteria

  • Hardcode either fromAccount or balance to be undefined and ensure component is gracefully rendering properly.

References

Sentry - https://sentry.io/organizations/metamask/issues/2426194283/?project=2299799&referrer=github_integration
This is most likely the same problem causing #2762
@estebanmino estebanmino added the type-bug Something isn't working label Jun 9, 2021
@estebanmino estebanmino changed the title Sentry: TypeError: undefined is not an object (evaluating 'f.balance') Play Store: TypeError: undefined is not an object (evaluating 'f.balance') Jun 9, 2021
@sentry-io
Copy link

sentry-io bot commented Jun 9, 2021

Sentry issue: METAMASK-MOBILE-Q9S

@sentry-io
Copy link

sentry-io bot commented Jun 9, 2021

Sentry issue: METAMASK-MOBILE-EW0

@sentry-io
Copy link

sentry-io bot commented Jun 9, 2021

Sentry issue: METAMASK-MOBILE-M0R

@sentry-io
Copy link

sentry-io bot commented Jun 9, 2021

Sentry issue: METAMASK-MOBILE-C3F

@sentry-io
Copy link

sentry-io bot commented Jun 9, 2021

Sentry issue: METAMASK-MOBILE-EET

@sentry-io
Copy link

sentry-io bot commented Jun 9, 2021

Sentry issue: METAMASK-MOBILE-PBN

@sentry-io
Copy link

sentry-io bot commented Jun 9, 2021

Sentry issue: METAMASK-MOBILE-KS8

@sentry-io
Copy link

sentry-io bot commented Jun 9, 2021

Sentry issue: METAMASK-MOBILE-KXE

@sentry-io
Copy link

sentry-io bot commented Jun 9, 2021

Sentry issue: METAMASK-MOBILE-DNG

@sentry-io
Copy link

sentry-io bot commented Jun 9, 2021

Sentry issue: METAMASK-MOBILE-QZ0

@sentry-io
Copy link

sentry-io bot commented Jun 9, 2021

Sentry issue: METAMASK-MOBILE-R2Y

@estebanmino estebanmino changed the title Play Store: TypeError: undefined is not an object (evaluating 'f.balance') TypeError: undefined is not an object (evaluating 'f.balance') Jun 9, 2021
@sethkfman sethkfman added the Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing label Jul 28, 2021
@omnat omnat added Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking and removed Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing labels Jul 29, 2021
@Cal-L Cal-L mentioned this issue Jul 29, 2021
Closed
@Cal-L Cal-L self-assigned this Jul 30, 2021
@Cal-L Cal-L mentioned this issue Aug 4, 2021
Merged
3 tasks
@Cal-L Cal-L added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Aug 4, 2021
@Cal-L Cal-L removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 1, 2021
@Cal-L Cal-L closed this as completed Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Cal-L Cal-L

Labels
Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking type-bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sethkfman @Cal-L @estebanmino @omnat