Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to TypeScript v5 stable #5984

Open
leotm opened this issue Mar 17, 2023 · 0 comments
Open

Migrate to TypeScript v5 stable #5984

leotm opened this issue Mar 17, 2023 · 0 comments
Labels
type-tech-debt Technical debt

Comments

@leotm
Copy link
Member

leotm commented Mar 17, 2023

Description

TypeScript 5 announced and released (March 16th, 2023)

and merged into React Native core (May 10th, 2023)

but we're delaying this since our MM shared ESLint config isn't compatible with v5 yet (still on ~4.8.4)
otherwise this will be introducing peer dependency warnings and potentially other incompatibilities

we're now ready since MM shared ESLint config TS v5 support (July 13th, 2023)
https://github.com/MetaMask/eslint-config/releases/tag/v12.1.0

Technical Details

Upgrade TS/ESLint devDeps first to support TS v5
or ESLint warns we're running an incompatible TS version
details: MetaMask/KeyringController#202 (comment)

Acceptance Criteria

TSC: 0 errors, 0-X (tolerated) warnings

Note TSC diagnostics stats

References

this can be a follow-up to

or before in order to fix errors and refactor while utilising TS v5 features

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-tech-debt Technical debt
Projects
None yet
Development

No branches or pull requests

1 participant