From d0ad75b105835d692ff17216b714ccf37598cf9a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9=20Fatia?= Date: Mon, 7 Feb 2022 19:50:52 +0000 Subject: [PATCH 1/8] Add credit card support and change copy --- .../UI/FiatOrders/PaymentMethodSelector/wyreApplePay.js | 2 +- app/components/UI/FiatOrders/orderProcessor/wyreApplePay.js | 2 +- locales/languages/en.json | 2 +- locales/languages/es.json | 1 - locales/languages/hi-in.json | 1 - locales/languages/id-id.json | 1 - locales/languages/ja-jp.json | 1 - locales/languages/ko-kr.json | 1 - locales/languages/pt-br.json | 1 - locales/languages/ru-ru.json | 1 - locales/languages/tl.json | 1 - locales/languages/vi-vn.json | 1 - 12 files changed, 3 insertions(+), 12 deletions(-) diff --git a/app/components/UI/FiatOrders/PaymentMethodSelector/wyreApplePay.js b/app/components/UI/FiatOrders/PaymentMethodSelector/wyreApplePay.js index 9536b88303f..f09686cafa7 100644 --- a/app/components/UI/FiatOrders/PaymentMethodSelector/wyreApplePay.js +++ b/app/components/UI/FiatOrders/PaymentMethodSelector/wyreApplePay.js @@ -58,7 +58,7 @@ const WyreApplePayPaymentMethod = ({ onPress }) => { {strings('fiat_on_ramp.fast_plus_lower_fees')} - {strings('fiat_on_ramp.debit_card_required')} + {strings('fiat_on_ramp.cards_type_required')} diff --git a/app/components/UI/FiatOrders/orderProcessor/wyreApplePay.js b/app/components/UI/FiatOrders/orderProcessor/wyreApplePay.js index ef88fc44c11..9c38c46b30a 100644 --- a/app/components/UI/FiatOrders/orderProcessor/wyreApplePay.js +++ b/app/components/UI/FiatOrders/orderProcessor/wyreApplePay.js @@ -528,7 +528,7 @@ const paymentOptions = { requestPayerPhone: true, requestPayerEmail: true, requestBilling: true, - merchantCapabilities: ['debit'], + merchantCapabilities: ['debit', 'credit'], }; const createPayload = (network, amount, address, currency, paymentDetails) => { diff --git a/locales/languages/en.json b/locales/languages/en.json index 3bec520ae1b..1ac7fcbd539 100644 --- a/locales/languages/en.json +++ b/locales/languages/en.json @@ -1379,7 +1379,7 @@ "no_countries_result": "No supported countries match “{{searchString}}”", "wyre_loading_rates": " ", "fast_plus_lower_fees": "Fast + lower fees", - "debit_card_required": "Lower fees, Debit card required", + "cards_type_required": "Visa or Mastercard only", "select_card_country": "Select the country where your card is registered (not where you are located).", "search_country": "Search for a country", "wyre_countries": "🇺🇸 U.S. + 33 countries, fees & limits vary", diff --git a/locales/languages/es.json b/locales/languages/es.json index c9dc63d4bc4..a2479ac563f 100644 --- a/locales/languages/es.json +++ b/locales/languages/es.json @@ -1337,7 +1337,6 @@ "no_countries_result": "Los países bi admitidos coinciden con “{{searchString}}”", "wyre_loading_rates": " ", "fast_plus_lower_fees": "Rápido y menores cuotas", - "debit_card_required": "Menores cuotas, se requiere tarjeta de débito", "select_card_country": "Seleccione el país donde esté registrada su tarjeta (no donde usted se encuentre).", "search_country": "Buscar un país", "wyre_countries": " EE. UU. Más de 33 países, las cuotas y los límites varían", diff --git a/locales/languages/hi-in.json b/locales/languages/hi-in.json index 5047b388363..5d0940147ce 100644 --- a/locales/languages/hi-in.json +++ b/locales/languages/hi-in.json @@ -1337,7 +1337,6 @@ "no_countries_result": "किसी समर्थित देश का {{searchString}} से मिलान नहीं हुआ", "wyre_loading_rates": " ", "fast_plus_lower_fees": "तेज़ + कम शुल्क", - "debit_card_required": "कम शुल्क, डेबिट कार्ड ज़रूरी", "select_card_country": "उस देश का चयन करें जहां आपका कार्ड पंजीकृत है (वह नहीं जहां आप मौजूद हैं)।", "search_country": "किसी देश को खोजें", "wyre_countries": " U.S. + 33 देश, शुल्क और सीमाएँ अलग-अलग होती हैं", diff --git a/locales/languages/id-id.json b/locales/languages/id-id.json index 44fd13b9d7b..05b258bbc89 100644 --- a/locales/languages/id-id.json +++ b/locales/languages/id-id.json @@ -1337,7 +1337,6 @@ "no_countries_result": "Tidak ada negara yang didukung yang cocok “{{searchString}}”", "wyre_loading_rates": " ", "fast_plus_lower_fees": "Biaya Cepat + lambat", - "debit_card_required": "Biaya lebih rendah, diperlukan kartu debit", "select_card_country": "Pilih negara tempat kartu Anda terdaftar (bukan tempat Anda berlokasi).", "search_country": "Cari negara", "wyre_countries": " AS + 33 negara, biaya & batasan berbeda", diff --git a/locales/languages/ja-jp.json b/locales/languages/ja-jp.json index 5a3646bde2e..3765e3614ec 100644 --- a/locales/languages/ja-jp.json +++ b/locales/languages/ja-jp.json @@ -1337,7 +1337,6 @@ "no_countries_result": "サポートされている国の一致がありません “{{searchString}}”", "wyre_loading_rates": " ", "fast_plus_lower_fees": "高速 + 低い手数料", - "debit_card_required": "低い手数料。デビット カードが必要です。", "select_card_country": "カードが登録されている国を選択してください (お客様の所在地ではありません)。", "search_country": "国の検索", "wyre_countries": " 米国 + 33 か国以上。手数料と限度額は異なります", diff --git a/locales/languages/ko-kr.json b/locales/languages/ko-kr.json index d1ea8af71ad..249f1b763c8 100644 --- a/locales/languages/ko-kr.json +++ b/locales/languages/ko-kr.json @@ -1337,7 +1337,6 @@ "no_countries_result": "지원 국가 가운데 “{{searchString}}” 없음", "wyre_loading_rates": " ", "fast_plus_lower_fees": "빠른 속도 + 낮은 수수료", - "debit_card_required": "낮은 수수료, 체크카드 필요", "select_card_country": "카드가 등록된 국가를 선택하십시오(거주 국가가 아님).", "search_country": "국가 검색", "wyre_countries": " U.S. + 33개가 넘는 국가, 수수료와 한도 상이", diff --git a/locales/languages/pt-br.json b/locales/languages/pt-br.json index 7227e661416..895369506f8 100644 --- a/locales/languages/pt-br.json +++ b/locales/languages/pt-br.json @@ -1337,7 +1337,6 @@ "no_countries_result": "Nenhum país disponível correspondente a “{{searchString}}”", "wyre_loading_rates": " ", "fast_plus_lower_fees": "Taxas rápidas e mais baixas", - "debit_card_required": "Menores taxas, Cartão de débito necessário", "select_card_country": "Selecione o país onde o seu cartão está registrado (e não aonde você se encontra).", "search_country": "Pesquisar por país", "wyre_countries": " U.S. + 33 países, taxas & limites variam", diff --git a/locales/languages/ru-ru.json b/locales/languages/ru-ru.json index 9fe13deaa73..4f3afead55e 100644 --- a/locales/languages/ru-ru.json +++ b/locales/languages/ru-ru.json @@ -1337,7 +1337,6 @@ "no_countries_result": "Нет совпадений с «{{searchString}}» в поддерживаемых странах", "wyre_loading_rates": " ", "fast_plus_lower_fees": "Быстро + низкие сборы", - "debit_card_required": "Низкие сборы, требуется дебетовая карта", "select_card_country": "Выберите страну, в которой зарегистрирована ваша карта (а не ту, где вы находитесь).", "search_country": "Поиск страны", "wyre_countries": " США + 33 страны, сборы и лимиты различаются", diff --git a/locales/languages/tl.json b/locales/languages/tl.json index 809452db9f5..1ba6b0bb320 100644 --- a/locales/languages/tl.json +++ b/locales/languages/tl.json @@ -1337,7 +1337,6 @@ "no_countries_result": "Walang sinusuportahang bansa ang tumutugma sa “{{searchString}}”", "wyre_loading_rates": " ", "fast_plus_lower_fees": "Mabilis + mas maliliit na bayarin", - "debit_card_required": "Mas maliliit na bayarin, Kailangan ng debit card", "select_card_country": "Piliin ang bansa kung saan naka-register ang iyong card (hindi ang lokasyon kung nasaan ka).", "search_country": "Maghanap ng bansa", "wyre_countries": " U.S. + 33 bansa, iba-iba ang mga bayarin at limitasyon", diff --git a/locales/languages/vi-vn.json b/locales/languages/vi-vn.json index af7fea1e933..17fad5b638e 100644 --- a/locales/languages/vi-vn.json +++ b/locales/languages/vi-vn.json @@ -1337,7 +1337,6 @@ "no_countries_result": "Không tìm thấy quốc gia được hỗ trợ nào khớp với “{{searchString}}”", "wyre_loading_rates": " ", "fast_plus_lower_fees": "Nhanh + phí thấp hơn", - "debit_card_required": "Phí thấp hơn, cần có thẻ ghi nợ", "select_card_country": "Chọn quốc gia phát hành thẻ của bạn (không phải nơi bạn cư trú).", "search_country": "Tìm kiếm quốc gia", "wyre_countries": " Hoa Kỳ + 33 quốc gia, phí và hạn mức không giống nhau", From 5240de65fb8b2b646782c4d1114571a3d19ec978 Mon Sep 17 00:00:00 2001 From: gantunesr Date: Tue, 8 Mar 2022 01:26:27 -0300 Subject: [PATCH 2/8] Upgrade version and build number --- android/app/build.gradle | 4 ++-- bitrise.yml | 4 ++-- ios/MetaMask.xcodeproj/project.pbxproj | 8 ++++---- package.json | 2 +- 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/android/app/build.gradle b/android/app/build.gradle index 2c97b139125..99734b12207 100644 --- a/android/app/build.gradle +++ b/android/app/build.gradle @@ -160,8 +160,8 @@ android { applicationId "io.metamask" minSdkVersion rootProject.ext.minSdkVersion targetSdkVersion rootProject.ext.targetSdkVersion - versionCode 827 - versionName "4.1.1" + versionCode 837 + versionName "4.3.0-creditcard" multiDexEnabled true testBuildType System.getProperty('testBuildType', 'debug') missingDimensionStrategy "minReactNative", "minReactNative46" diff --git a/bitrise.yml b/bitrise.yml index bc78c3d7b96..852e8cb9cb1 100644 --- a/bitrise.yml +++ b/bitrise.yml @@ -323,10 +323,10 @@ app: PROJECT_LOCATION_IOS: ios - opts: is_expand: false - VERSION_NAME: 4.1.1 + VERSION_NAME: 4.3.0-creditcard - opts: is_expand: false - VERSION_NUMBER: 827 + VERSION_NUMBER: 837 - opts: is_expand: false ANDROID_APK_LINK: '' diff --git a/ios/MetaMask.xcodeproj/project.pbxproj b/ios/MetaMask.xcodeproj/project.pbxproj index 5afff5a1094..120b6225318 100644 --- a/ios/MetaMask.xcodeproj/project.pbxproj +++ b/ios/MetaMask.xcodeproj/project.pbxproj @@ -817,7 +817,7 @@ CODE_SIGN_ENTITLEMENTS = MetaMask/MetaMaskDebug.entitlements; CODE_SIGN_IDENTITY = "iPhone Developer"; CODE_SIGN_STYLE = Manual; - CURRENT_PROJECT_VERSION = 827; + CURRENT_PROJECT_VERSION = 837; DEAD_CODE_STRIPPING = YES; DEBUG_INFORMATION_FORMAT = dwarf; DEVELOPMENT_TEAM = 48XVW22RCG; @@ -853,7 +853,7 @@ "\"$(SRCROOT)/MetaMask/System/Library/Frameworks\"", ); LLVM_LTO = YES; - MARKETING_VERSION = 4.1.1; + MARKETING_VERSION = 4.3.0-creditcard; ONLY_ACTIVE_ARCH = YES; OTHER_CFLAGS = ( "$(inherited)", @@ -884,7 +884,7 @@ CODE_SIGN_ENTITLEMENTS = MetaMask/MetaMask.entitlements; CODE_SIGN_IDENTITY = "iPhone Distribution"; CODE_SIGN_STYLE = Manual; - CURRENT_PROJECT_VERSION = 827; + CURRENT_PROJECT_VERSION = 837; DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym"; DEVELOPMENT_TEAM = 48XVW22RCG; FRAMEWORK_SEARCH_PATHS = ( @@ -919,7 +919,7 @@ "\"$(SRCROOT)/MetaMask/System/Library/Frameworks\"", ); LLVM_LTO = YES; - MARKETING_VERSION = 4.1.1; + MARKETING_VERSION = 4.3.0-creditcard; ONLY_ACTIVE_ARCH = NO; OTHER_CFLAGS = ( "$(inherited)", diff --git a/package.json b/package.json index b70def28ced..d98509b0e3b 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "metamask", - "version": "4.1.0", + "version": "4.3.0-creditcard", "private": true, "scripts": { "audit:ci": "./scripts/yarn-audit.sh", From 5d17dcfbf129ea18cda3f1ac3b44e1f3bd2239f3 Mon Sep 17 00:00:00 2001 From: gantunesr Date: Tue, 8 Mar 2022 09:19:34 -0300 Subject: [PATCH 3/8] Upgrade version and build number --- android/app/build.gradle | 4 ++-- bitrise.yml | 4 ++-- ios/MetaMask.xcodeproj/project.pbxproj | 8 ++++---- package.json | 2 +- 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/android/app/build.gradle b/android/app/build.gradle index 99734b12207..11418ae7fb6 100644 --- a/android/app/build.gradle +++ b/android/app/build.gradle @@ -160,8 +160,8 @@ android { applicationId "io.metamask" minSdkVersion rootProject.ext.minSdkVersion targetSdkVersion rootProject.ext.targetSdkVersion - versionCode 837 - versionName "4.3.0-creditcard" + versionCode 838 + versionName "4.3.0" multiDexEnabled true testBuildType System.getProperty('testBuildType', 'debug') missingDimensionStrategy "minReactNative", "minReactNative46" diff --git a/bitrise.yml b/bitrise.yml index 852e8cb9cb1..329ad892c62 100644 --- a/bitrise.yml +++ b/bitrise.yml @@ -323,10 +323,10 @@ app: PROJECT_LOCATION_IOS: ios - opts: is_expand: false - VERSION_NAME: 4.3.0-creditcard + VERSION_NAME: 4.3.0 - opts: is_expand: false - VERSION_NUMBER: 837 + VERSION_NUMBER: 838 - opts: is_expand: false ANDROID_APK_LINK: '' diff --git a/ios/MetaMask.xcodeproj/project.pbxproj b/ios/MetaMask.xcodeproj/project.pbxproj index 120b6225318..93eec4de823 100644 --- a/ios/MetaMask.xcodeproj/project.pbxproj +++ b/ios/MetaMask.xcodeproj/project.pbxproj @@ -817,7 +817,7 @@ CODE_SIGN_ENTITLEMENTS = MetaMask/MetaMaskDebug.entitlements; CODE_SIGN_IDENTITY = "iPhone Developer"; CODE_SIGN_STYLE = Manual; - CURRENT_PROJECT_VERSION = 837; + CURRENT_PROJECT_VERSION = 838; DEAD_CODE_STRIPPING = YES; DEBUG_INFORMATION_FORMAT = dwarf; DEVELOPMENT_TEAM = 48XVW22RCG; @@ -853,7 +853,7 @@ "\"$(SRCROOT)/MetaMask/System/Library/Frameworks\"", ); LLVM_LTO = YES; - MARKETING_VERSION = 4.3.0-creditcard; + MARKETING_VERSION = 4.3.0; ONLY_ACTIVE_ARCH = YES; OTHER_CFLAGS = ( "$(inherited)", @@ -884,7 +884,7 @@ CODE_SIGN_ENTITLEMENTS = MetaMask/MetaMask.entitlements; CODE_SIGN_IDENTITY = "iPhone Distribution"; CODE_SIGN_STYLE = Manual; - CURRENT_PROJECT_VERSION = 837; + CURRENT_PROJECT_VERSION = 838; DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym"; DEVELOPMENT_TEAM = 48XVW22RCG; FRAMEWORK_SEARCH_PATHS = ( @@ -919,7 +919,7 @@ "\"$(SRCROOT)/MetaMask/System/Library/Frameworks\"", ); LLVM_LTO = YES; - MARKETING_VERSION = 4.3.0-creditcard; + MARKETING_VERSION = 4.3.0; ONLY_ACTIVE_ARCH = NO; OTHER_CFLAGS = ( "$(inherited)", diff --git a/package.json b/package.json index d98509b0e3b..ec604a3a6c1 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "metamask", - "version": "4.3.0-creditcard", + "version": "4.3.0", "private": true, "scripts": { "audit:ci": "./scripts/yarn-audit.sh", From 14660728ad63e78f263de83ea6be21b03eadb653 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9=20Fatia?= Date: Thu, 10 Mar 2022 10:39:33 +0000 Subject: [PATCH 4/8] Improve missleading copy when fiat orders fails --- app/components/UI/FiatOrders/index.js | 2 ++ locales/languages/en.json | 2 ++ 2 files changed, 4 insertions(+) diff --git a/app/components/UI/FiatOrders/index.js b/app/components/UI/FiatOrders/index.js index 92555bc1b66..84d37bd7043 100644 --- a/app/components/UI/FiatOrders/index.js +++ b/app/components/UI/FiatOrders/index.js @@ -70,6 +70,7 @@ export const getNotificationDetails = (fiatOrder) => { title: strings('fiat_on_ramp.notifications.purchase_failed_title', { currency: fiatOrder.cryptocurrency, }), + description: strings('fiat_on_ramp.notifications.purchase_failed_description'), status: 'error', }; } @@ -77,6 +78,7 @@ export const getNotificationDetails = (fiatOrder) => { return { ...baseNotificationDetails, title: strings('fiat_on_ramp.notifications.purchase_cancelled_title'), + description: strings('fiat_on_ramp.notifications.purchase_cancelled_description'), status: 'cancelled', }; } diff --git a/locales/languages/en.json b/locales/languages/en.json index 972c2a257dd..e49096f4477 100644 --- a/locales/languages/en.json +++ b/locales/languages/en.json @@ -1433,7 +1433,9 @@ "plus_fee": "Plus a {{fee}} fee", "notifications": { "purchase_failed_title": "Purchase of {{currency}} has failed! Please try again, sorry for the inconvenience!", + "purchase_failed_description": "Verify your payment method and card support", "purchase_cancelled_title": "Your purchase was cancelled", + "purchase_cancelled_description": "Verify your payment method and card support", "purchase_completed_title": "Your purchase of {{amount}} {{currency}} was successful!", "purchase_completed_description": "Your {{currency}} is now available", "purchase_pending_title": "Processing your purchase of {{currency}}", From e5cac908c2e13fb01f2e2b04ca55e5b813dbfdcc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9=20Fatia?= Date: Thu, 10 Mar 2022 14:47:07 +0000 Subject: [PATCH 5/8] Revert version to match main branch --- android/app/build.gradle | 4 ++-- bitrise.yml | 6 +++--- ios/MetaMask.xcodeproj/project.pbxproj | 8 ++++---- package.json | 2 +- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/android/app/build.gradle b/android/app/build.gradle index f016c13fabc..56f7957704d 100644 --- a/android/app/build.gradle +++ b/android/app/build.gradle @@ -160,8 +160,8 @@ android { applicationId "io.metamask" minSdkVersion rootProject.ext.minSdkVersion targetSdkVersion rootProject.ext.targetSdkVersion - versionCode 838 - versionName "4.3.0" + versionCode 834 + versionName "4.2.2" multiDexEnabled true testBuildType System.getProperty('testBuildType', 'debug') missingDimensionStrategy "minReactNative", "minReactNative46" diff --git a/bitrise.yml b/bitrise.yml index c88089cc3ad..17d69125c33 100644 --- a/bitrise.yml +++ b/bitrise.yml @@ -68,7 +68,7 @@ workflows: - script@1: inputs: - content: |- - #!/usr/bin/env bash + #!/usr/bin/env bash echo 'weew - everything passed!' title: All Tests Passed is_always_run: false @@ -323,10 +323,10 @@ app: PROJECT_LOCATION_IOS: ios - opts: is_expand: false - VERSION_NAME: 4.3.0 + VERSION_NAME: 4.2.2 - opts: is_expand: false - VERSION_NUMBER: 838 + VERSION_NUMBER: 834 - opts: is_expand: false ANDROID_APK_LINK: '' diff --git a/ios/MetaMask.xcodeproj/project.pbxproj b/ios/MetaMask.xcodeproj/project.pbxproj index 93eec4de823..ad201c2d333 100644 --- a/ios/MetaMask.xcodeproj/project.pbxproj +++ b/ios/MetaMask.xcodeproj/project.pbxproj @@ -817,7 +817,7 @@ CODE_SIGN_ENTITLEMENTS = MetaMask/MetaMaskDebug.entitlements; CODE_SIGN_IDENTITY = "iPhone Developer"; CODE_SIGN_STYLE = Manual; - CURRENT_PROJECT_VERSION = 838; + CURRENT_PROJECT_VERSION = 834; DEAD_CODE_STRIPPING = YES; DEBUG_INFORMATION_FORMAT = dwarf; DEVELOPMENT_TEAM = 48XVW22RCG; @@ -853,7 +853,7 @@ "\"$(SRCROOT)/MetaMask/System/Library/Frameworks\"", ); LLVM_LTO = YES; - MARKETING_VERSION = 4.3.0; + MARKETING_VERSION = 4.2.2; ONLY_ACTIVE_ARCH = YES; OTHER_CFLAGS = ( "$(inherited)", @@ -884,7 +884,7 @@ CODE_SIGN_ENTITLEMENTS = MetaMask/MetaMask.entitlements; CODE_SIGN_IDENTITY = "iPhone Distribution"; CODE_SIGN_STYLE = Manual; - CURRENT_PROJECT_VERSION = 838; + CURRENT_PROJECT_VERSION = 834; DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym"; DEVELOPMENT_TEAM = 48XVW22RCG; FRAMEWORK_SEARCH_PATHS = ( @@ -919,7 +919,7 @@ "\"$(SRCROOT)/MetaMask/System/Library/Frameworks\"", ); LLVM_LTO = YES; - MARKETING_VERSION = 4.3.0; + MARKETING_VERSION = 4.2.2; ONLY_ACTIVE_ARCH = NO; OTHER_CFLAGS = ( "$(inherited)", diff --git a/package.json b/package.json index 05a3e93c65a..e5b5e65a2e2 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "metamask", - "version": "4.3.0", + "version": "4.2.2", "private": true, "scripts": { "audit:ci": "./scripts/yarn-audit.sh", From e606672379a8185af22b544e6ab2841421612540 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9=20Fatia?= Date: Thu, 10 Mar 2022 14:48:05 +0000 Subject: [PATCH 6/8] Remove space --- android/app/build.gradle | 1 - 1 file changed, 1 deletion(-) diff --git a/android/app/build.gradle b/android/app/build.gradle index 56f7957704d..d4655e77f54 100644 --- a/android/app/build.gradle +++ b/android/app/build.gradle @@ -277,7 +277,6 @@ dependencies { debugImplementation("com.facebook.flipper:flipper-fresco-plugin:${FLIPPER_VERSION}") { exclude group:'com.facebook.flipper' } - if (enableHermes) { def hermesPath = "../../node_modules/hermes-engine/android/"; debugImplementation files(hermesPath + "hermes-debug.aar") From 9b9640c51809dfb3c652b569fb1f3d067f944f1a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9=20Fatia?= Date: Thu, 10 Mar 2022 14:48:29 +0000 Subject: [PATCH 7/8] Add space --- android/app/build.gradle | 1 + 1 file changed, 1 insertion(+) diff --git a/android/app/build.gradle b/android/app/build.gradle index d4655e77f54..56f7957704d 100644 --- a/android/app/build.gradle +++ b/android/app/build.gradle @@ -277,6 +277,7 @@ dependencies { debugImplementation("com.facebook.flipper:flipper-fresco-plugin:${FLIPPER_VERSION}") { exclude group:'com.facebook.flipper' } + if (enableHermes) { def hermesPath = "../../node_modules/hermes-engine/android/"; debugImplementation files(hermesPath + "hermes-debug.aar") From 5a398004f58d65bf615c6c1d76b635bff3be45a7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9=20Fatia?= Date: Thu, 10 Mar 2022 14:49:30 +0000 Subject: [PATCH 8/8] build.gradle equals main --- android/app/build.gradle | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/android/app/build.gradle b/android/app/build.gradle index 56f7957704d..daeac40b4a1 100644 --- a/android/app/build.gradle +++ b/android/app/build.gradle @@ -277,7 +277,7 @@ dependencies { debugImplementation("com.facebook.flipper:flipper-fresco-plugin:${FLIPPER_VERSION}") { exclude group:'com.facebook.flipper' } - + if (enableHermes) { def hermesPath = "../../node_modules/hermes-engine/android/"; debugImplementation files(hermesPath + "hermes-debug.aar")