From 62f89c58ed83e4e64646f09115117b2120ecf33d Mon Sep 17 00:00:00 2001 From: Sylva Elendu Date: Tue, 27 Feb 2024 15:36:03 +0100 Subject: [PATCH] fix: update origin passed to ppom for send transactions (#8742) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Context: https://consensys.slack.com/archives/C05HZHDS89Z/p1708946195217929 Pass origin as `metamask` for ppom validate request Fixes: 1. Go to this page... 2. 3. - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --- app/components/Views/confirmations/SendFlow/Confirm/index.js | 2 +- app/core/TransactionTypes.js | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/app/components/Views/confirmations/SendFlow/Confirm/index.js b/app/components/Views/confirmations/SendFlow/Confirm/index.js index d02516c6bd5..4bd4d20cd4d 100644 --- a/app/components/Views/confirmations/SendFlow/Confirm/index.js +++ b/app/components/Views/confirmations/SendFlow/Confirm/index.js @@ -509,7 +509,7 @@ class Confirm extends PureComponent { id, jsonrpc: '2.0', method: 'eth_sendTransaction', - origin: TransactionTypes.MMM, + origin: TransactionTypes.MM, params: [ { from, diff --git a/app/core/TransactionTypes.js b/app/core/TransactionTypes.js index 10883e44a9a..0aa9bcd753d 100644 --- a/app/core/TransactionTypes.js +++ b/app/core/TransactionTypes.js @@ -12,4 +12,5 @@ export default { ERC1155: 'ERC1155', }, MMM: 'MetaMask Mobile', + MM: 'metamask', };