Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF viewer: Browser compability #378

Closed
reginafcompton opened this issue Nov 15, 2018 · 7 comments
Closed

PDF viewer: Browser compability #378

reginafcompton opened this issue Nov 15, 2018 · 7 comments
Assignees

Comments

@reginafcompton
Copy link
Contributor

The PDF viewer does not behave as expected in some browsers.

Edge browser

The embedded PDF pane is blank. Printing from the embedded PDF is also blank.

Chrome 69.0.3497.92, os x el capitan 10.11.6

screen shot 2018-09-14 at 4 48 33 pm

@hancush
Copy link
Collaborator

hancush commented Apr 12, 2019

so i'm seeing this again in chrome and firefox, but it resolves when i refresh the page. if it's important, the events i'm viewing all have new documents, i.e., those documents are not yet in the cache. in the console, there is a message about cross-origin resource sharing. these docs suggest we can remedy this issue (or at least the manifestation i'm seeing) by adding an nginx directive.

@hancush
Copy link
Collaborator

hancush commented Jun 17, 2019

update: having dealt with a similar issue in #433, i'm pretty confident this is related to cors. we use flask-cors in the property-image-cache application to add the appropriate headers, so that may not be working as expected. if it is working as expected, then there may be something wonky going on how we're requesting and displaying the document on the councilmatic side. if it's the latter, then this may be addressed by swapping the library we use to render pdfs, as outlined in #294 (comment).

@hancush
Copy link
Collaborator

hancush commented Aug 22, 2019

hmmmmm mozilla/pdf.js#4530 (comment)

@hancush
Copy link
Collaborator

hancush commented Aug 22, 2019

S3ResponseError: S3ResponseError: 403 Forbidden
<?xml version="1.0" encoding="UTF-8"?>
<Error><Code>AccessDenied</Code><Message>Access Denied</Message><RequestId>B469F9930C08BD93</RequestId><HostId>cZQ1GD4VPshpbYfR4oRZpmdcTe4ix4UJksSEMtN927A3sC6FPPkPFQQjV48QlEbLmkfrYftP45o=</HostId></Error>

hmmmmmmm https://sentry.io/organizations/datamade/issues/973621844/?project=64504&query=is%3Aunresolved

mmmmmm
https://stackoverflow.com/questions/10854095/boto-exception-s3responseerror-s3responseerror-403-forbidden
mmmmm

@hancush
Copy link
Collaborator

hancush commented Aug 22, 2019

i went into the aws iam console and gave the pic user permission to set the acl on existing objects. then, i followed the instructions here #443 (comment) to remove an event agenda from the cache, and tried to visit the page again to replicate this issue. hark, things behaved as expected!

@hancush
Copy link
Collaborator

hancush commented Aug 26, 2019

@shrayshray i believe i've solved this! any objection to closing?

@hancush hancush closed this as completed Aug 26, 2019
@hancush hancush reopened this Aug 26, 2019
@shrayshray
Copy link
Collaborator

Okay to close, things seem to be working as expected. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants