-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not merge - traefik persistent volume #4
Conversation
volume { | ||
name = "traefik-certs" | ||
persistent_volume_claim { | ||
claim_name = "persistent-volume-claim-2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be referenced. If you create your PVC with https://registry.terraform.io/providers/hashicorp/kubernetes/latest/docs/resources/persistent_volume_claim then you can do something like kubernetes_persistent_volume_claim.[resource name].name
reclaim_policy = var.reclaim_policy | ||
} | ||
|
||
resource "kubernetes_manifest" "traefik-persistent-volume" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
} | ||
|
||
resource "kubernetes_manifest" "persistent-volume-claim" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,13 @@ | |||
apiVersion: v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should not be committed
@@ -0,0 +1,13 @@ | |||
apiVersion: v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should not be committed
|
||
|
||
|
||
resource "kubernetes_persistent_volume_claim" "persistent-volume-claim" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"persistent-volume-claim" - use _ and specify a bit more in the name, traefik_ingress_pvc should work
} | ||
} | ||
|
||
resource "kubernetes_persistent_volume" "traefik-persistent-volume" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change to _
|
||
resource "kubernetes_persistent_volume_claim" "persistent-volume-claim" { | ||
metadata { | ||
name = "persistent-volume-claim" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use name to ensure uniqueness
"${var.name}-traefik-ingress"
Work was redone in a different PR, closing |
Reference Issues or PRs
What does this implement/fix?
Put a
x
in the boxes that applyTesting
Any other comments?