Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

International Support #331

Open
bpepple opened this issue Jan 19, 2025 · 2 comments
Open

International Support #331

bpepple opened this issue Jan 19, 2025 · 2 comments
Assignees
Labels
api An API bug/feature breaking An API breaking change enhancement New feature or request

Comments

@bpepple
Copy link
Member

bpepple commented Jan 19, 2025

Is your feature request related to a problem?
To handle non-US based publishers, we need to add some international support.

Describe the solution you'd like
At a minimum, we should add the following:

  • Add a country field to the Publisher model
  • Modify the price field to be a list that can handle different currencies

Most likely we could use a library like PyCountry, django-countries, or django-money to simplify the code.

Additional context
Modifying the price field will be a API breaking change, so we should see what other changes we want to make, like adding Versioning to the API. This will also need to announced in advanced, so the various consumers are made aware.

@bpepple bpepple added api An API bug/feature breaking An API breaking change enhancement New feature or request labels Jan 19, 2025
@bpepple
Copy link
Member Author

bpepple commented Jan 19, 2025

We should look at #181 when working on this bug.

@bpepple bpepple self-assigned this Jan 19, 2025
@bpepple bpepple moved this to Backlog in International Support Jan 20, 2025
@bpepple bpepple moved this from Backlog to In progress in International Support Jan 20, 2025
@bpepple
Copy link
Member Author

bpepple commented Jan 20, 2025

Added Country field to the Publisher model with #332

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api An API bug/feature breaking An API breaking change enhancement New feature or request
Projects
Status: In progress
Development

No branches or pull requests

1 participant