Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repositories with multiple RBFs #37

Open
sorgelig opened this issue Feb 5, 2020 · 3 comments
Open

Repositories with multiple RBFs #37

sorgelig opened this issue Feb 5, 2020 · 3 comments

Comments

@sorgelig
Copy link
Member

sorgelig commented Feb 5, 2020

There is already one repository (Atari 800) with multiple RBFs. And i'm not excluding that other similar repos may appear later.
Instead of processing it specifically i propose a generic automated way. The RBF names equal to .qsf names in the root. So, basically you scan the root for qsf files and you already have possible RBFs in release folder.
Atari800.qsf -> Atari800_YYYYMMDD.rbf
Atari5200.qsf -> Atari5200_YYYYMMDD.rbf

This is true even for repos with single RBF.

@Locutus73
Copy link
Member

Locutus73 commented Feb 20, 2020

Hi this could be an idea to explore, but I see some problems here to think about:

  1. The only core with two distinct RBF files in the releases folder is the Atari 800 one which would still need custom code because Atari800 rbf must go into _Computer dir, while Atari5200 rbf must go into _Console. Parsing qsf files would't help with this, it would be useful for cores with multiple rbf in the same category.
  2. Some cores don't have the qsf file in the root of the repo, but in a different dir, i.e. PDP1 has the qsf in /src, Apple-I under /boards/MiSTer.
  3. Sometimes qsf and rbf case don't match, i.e. sharpmz vs SharpMZ, but this isn't a real problem, I would search ignoring case.
  4. Sometimes there are more than one qsf, but only one rbf, i.e. Minimig.qsf and Minimig_Q13.qsf vs Minimig rbf; this isn't a real problem too.

1 and 2 are the biggest problems I see in this approach, but maybe we can find a solution.

@sorgelig
Copy link
Member Author

  1. I will look into those repositories.
  2. rbf name always matches the qsf name. The difference in cases because it's how qsf file is listed inside qpf. Since windows doesn't care of file cases, it may mix it.
  3. this is not a problem. If script can't find a matching rbf, then simply ignore it.

@Locutus73
Copy link
Member

Yeah, 3 and 4 aren't real problems, 1 and 2 are more interesting to study.
For 2 I gave a pair of repos as example, I'm not sure if there are (or aren't) others with strange directory structure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants