Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updater always downloads to /media/fat/games #81

Open
Paradox opened this issue May 4, 2022 · 1 comment
Open

Updater always downloads to /media/fat/games #81

Paradox opened this issue May 4, 2022 · 1 comment

Comments

@Paradox
Copy link

Paradox commented May 4, 2022

No matter where your game directories are, for example /media/usb0/games the updater always puts new files in /media/fat/games/corename changing the base path doesn't help here, as you might have some in fat and some in usb0, also, this would cause the cores, and everything else to always be downloaded to /media/usb0, which is not the desired outcome, here. I'm working on a solution, similar to the one used in the BIOS Getter script, which was also added to the mame and hbmame getter scripts, after I submitted a pull request to that repo, based on the BIOS Getter method. Also, after you move those files to the proper directories, manually, the updater will happily redownload them the next time it's run. I can understand new cores having the game directory put on /media/fat/games, but, once the user has moved that directory somewhere else, the downloader should use that location in future updates.

I also have a separate issue with palettes being in the game directory, instead of its own directory, but, that is an issue with MiSTer main, and the cores, themselves, even though they seem to think it's an issue for the updater, however, this change would at least make that issue a bit more bearable, as long as the palette files are dropped in the correct place.

@sorgelig
Copy link
Member

sorgelig commented May 4, 2022

palettes are handled by cores directly without involving Main. So they are similar to roms and thus in correct places.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants