-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change weatherforecast and currentweather unit display #1503
Comments
A PR is more than welcome! Thanks! |
Merged. |
I will also change it for the new weather module. Done will be in the next pr |
Handled in #1510 for the new weather module. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi everybody,
I just started building/configuring my own MM and found a bug using "default" for the units. The degree symbol should not be displayed. It is degree Celsius and degree Fahrenheit, but not degree Kelvin.
weatherforecast
https://github.com/MichMich/MagicMirror/blob/de57daa3cd881ce1a14b88307bf61e8109879c81/modules/default/weatherforecast/weatherforecast.js#L145-L158
currentweather
https://github.com/MichMich/MagicMirror/blob/de57daa3cd881ce1a14b88307bf61e8109879c81/modules/default/currentweather/currentweather.js#L200-L213
https://github.com/MichMich/MagicMirror/blob/de57daa3cd881ce1a14b88307bf61e8109879c81/modules/default/currentweather/currentweather.js#L221
I suggest changing the display for both modules like this:
currentweather
weatherforecast
If these changes are okay with you, I will open two PR for this issue.
The text was updated successfully, but these errors were encountered: