Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect use of deprecated attribute #34

Closed
estebank opened this issue Dec 27, 2018 · 1 comment
Closed

Incorrect use of deprecated attribute #34

estebank opened this issue Dec 27, 2018 · 1 comment

Comments

@estebank
Copy link

rust-lang/rust#56896 is making the correct use of deprecated mandatory in rustc. We can't apply this as a hard error due to the following use in gcode:

[INFO] [stderr]     Checking gcode v0.3.1 (/opt/crater/workdir)
[INFO] [stderr] error: expected meta item sequence
[INFO] [stderr]   --> src/types.rs:53:5
[INFO] [stderr]    |
[INFO] [stderr] 53 |     #[deprecated = "You probably want the `Gcode::major_number()` and `Gcode::minor_number()` methods instead"]
[INFO] [stderr]    |     ^^--------------------------------------------------------------------------------------------------------^
[INFO] [stderr]    |       |
[INFO] [stderr]    |       help: use the `note` key: `deprecated(note = "You probably want the `Gcode::major_number()` and `Gcode::minor_number()` methods instead")`
[INFO] [stderr] 
[INFO] [stderr] error: expected meta item sequence
[INFO] [stderr]   --> src/types.rs:53:5
[INFO] [stderr]    |
[INFO] [stderr] 53 |     #[deprecated = "You probably want the `Gcode::major_number()` and `Gcode::minor_number()` methods instead"]
[INFO] [stderr]    |     ^^--------------------------------------------------------------------------------------------------------^
[INFO] [stderr]    |       |
[INFO] [stderr]    |       help: use the `note` key: `deprecated(note = "You probably want the `Gcode::major_number()` and `Gcode::minor_number()` methods instead")`
@Michael-F-Bryan
Copy link
Owner

Thanks for the issue @estebank. I've created a side branch with the fix, and made a new release on crates.io.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants