Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-monitor and empty-workspace detection #11

Open
Coffei opened this issue Dec 16, 2021 · 4 comments
Open

Multi-monitor and empty-workspace detection #11

Coffei opened this issue Dec 16, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@Coffei
Copy link

Coffei commented Dec 16, 2021

Hi,

first of all thanks for the great extension!

I noticed the unused-workspace detection doesn't work well if you use multiple monitors and workspaces only on the primary one (which I believe is the default for Gnome). If you have some window on the non-primary monitor this plugin registers it on every workspace, thus every workspace is displayed as active.

I think the detection should only consider windows on the primary display in this case, would it be possible to change this behaviour? Perhaps it could be based on the gnome configuration (you can also span workspaces on all monitors) or it can be a config of the extension.

@MichaelAquilina MichaelAquilina added the bug Something isn't working label Dec 16, 2021
@MichaelAquilina
Copy link
Owner

This definitely is a bug. I dont use multiple monitors myself so its not a big surprise I did not catch this. I cant promise I'll get a fix out soon but I encourage you try giving a go at fixing it yourself and open a PR :)

@Coffei
Copy link
Author

Coffei commented Dec 17, 2021

Ok, thanks. I have zero knowledge of Gnome extensions but this may be a good reason to learn. I'll see what I can do.

@Coffei
Copy link
Author

Coffei commented Dec 17, 2021

This is related to #8. The PR is basically what I wanted to do, unfortunately the solution has some issues as mentioned in the PR. I'll try to at least test the fix, since I am not sure I can improve it.

@MichaelAquilina
Copy link
Owner

I actually did not even notice that PR because I am not notified of draft PRs (I think). Thanks for pointing it out to me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants