Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipenv installation in 'developer/editable' mode. #148

Open
rnc opened this issue Feb 11, 2021 · 0 comments
Open

Pipenv installation in 'developer/editable' mode. #148

rnc opened this issue Feb 11, 2021 · 0 comments

Comments

@rnc
Copy link
Contributor

rnc commented Feb 11, 2021

Issue Details

Please provide the following details when opening an issue:

Operating System (uname -a)

Fedora 33

zsh version (zsh --version)

5.8

autoswitch-virtualenv version

echo "$AUTOSWITCH_VERSION"
3.1.1

How is zsh-autoswitch-virtualenv installed?

  • Other (please specify)

Manually using checked out repository

Steps to reproduce the issue

Currently install_requirements will install in editable mode by default. However, the pipenv block in mkvenv does not just installs in dev mode. This is a mis-match and could be solved with

diff --git a/autoswitch_virtualenv.plugin.zsh b/autoswitch_virtualenv.plugin.zsh
index 87123c1..f715ddd 100644
--- a/autoswitch_virtualenv.plugin.zsh
+++ b/autoswitch_virtualenv.plugin.zsh
@@ -294,7 +294,7 @@ function mkvenv()
             return
         fi
         # TODO: detect if this is already installed
-        pipenv install --dev $params
+        pipenv install --dev --editable $params .
         _activate_pipenv
         return
     elif [[ "$venv_type" == "poetry" ]]; then
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant