-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request - GCC High support #26
Comments
Hello! Thank you for the support! The tool is built on modules where the core foundation is doing nothing but managing settings, main window, loading modules etc. The idea from the beginning was to support multiple cloud environments that can be managed by public APIs. I don't work with any GCC High tenants so I am not sure what the APIs would look like, if there is a difference in authentication etc. Not even sure if there are any GCC High implementations here in Australia. |
Hiya! Apologize for the delay with my response here. I did find that some functions (such as configuration policy export) worked when I changed endpoint URLs (.com to .us) in one of your connection modules, but I haven't dug too deep into it quite yet. Other utilities that use AzureAD and Microsoft.Graph.Intune modules seem to connect just fine to GCC High tenants as well (since arguments can target different clouds). |
Hello! I uploaded a new version so download a copy of the master branch and try. You can change Cloud in Settings. Note that I have not tested this at all since I have no access to US Government or China Clouds. I am not sure how it is going to react when swapping between Azure AD Clouds, if it works, requires a restart of the script etc. Please test and let me know how it goes. Thank you! |
Hiya! Excited to give it a try, I'll report back here after giving the new build a spin. Thanks! |
Hey! So I had to change the following lines to get connected to my test GCC High tenant: MSGraph.psm1: After making those adjustments I was able to review GCC high supported configurations (some items like feature updates will error because it currently isn't supported). I haven't had a chance to test anything other than navigation today, so I'll update tomorrow. |
Thank you for testing. Sorry that I missed changing the graph. I'll include that in the next release. |
No problem! Thanks for looking at this! I'll continue testing tomorrow. |
So far, exporting and importing seem to work just fine. Documentation tasks as well. Still running through each feature! |
Thank you for the update! I am adding an option in Settings where you can select which GCC you are connecting to. It's the same endpoint for login but different Graph. Do you use the same account in different GCC environments or is that impossible? |
Just to clarify, 'GCC' itself uses public endpoints (Worldwide +GCC is how they label it), but 'GCC High' will use gov-related endpoints. In my experience, GCC High shares no endpoints with any public cloud endpoints (these typically end in *.us). Right now you'll have to use a unique account for each different GCC High environment. |
Hello! I uploaded a new version where you can select GCC type in Settings. It would be interesting to see how the test goes. It would also be good to see if there is a property on the Organisation or the user that specifies the GCC level. Can GCC account be a guest of another GCC tenant at any level? Cheers |
Hello! How are you going with the testing? Can I close this or do you want me to look at anything else for the GCC support? Cheers! |
Hello! Apologize for the delay here. I'm going to try your latest build and get back to you during the day tomorrow. Thanks! |
I had a moment to test tonight, so I'm still unable to connect without making modifications to the MSALAuthentication module, changing some endpoints from .com to .us. Here's the log result of Tenant Settings > Azure Login set to "Azure AD US Government" and Tenant Settings > GCC Environment set to "GCC High" only - no MSALAuthentication module changes:
This is the result after I make the following changes to the MSALAuthentication module. After the changes below, it seems to work within GCC High environments.
For some reason the tenant settings don't appear to work. One way to test if this works is if the login UI isn't pointing to commercial/public endpoints right away, but instead to GCC High/USGov (.us) endpoints. Hopefully this is clear - let me know if you need anything at all! Thank you very much! |
Thank you for testing! Well, that didn't go as planned. For a couple of reasons so I went back to the drawing board and redesigned it completely. I added a new option: Show Azure AD login menu. Go in to Settings and enable it (NOT Tenant settings!) Unpack the Zip file. Copy There might be on thing left to change in the code but I hope this will be enough and that this includes all the changes. Let me know how it goes |
Wow you're fast! This is working wonderfully! Tested in both GCC High and GCC tenants and everything is working from what I can tell. I'll let you know if any problems come up in future use. Thanks! |
Hello! That is great news! Do you cache your user tokens? If you do, does it work swapping between them? Cheers! |
Hiya! Yes and it appears to work so far! I've loaded up a few different tenants with the same build and things appear to cache correctly. |
This is now included in 3.5.0 but I will send you a new version to test. The new MSAL.DLL supports logging in to US/China cloud via public endpoints. I'll let you know when I have a version for you to test |
Closing this issue since it has been confirmed working in both GCC and China. Please reopen a case if there are any additional issues. Cheers |
Hey!
Wanted to say that you make a pretty awesome tool here and I really appreciate you putting this together. This might be a big ask - are there any plans to support GCC High (or any non commercial cloud environments) by any chance? I'd love to be able to use this tool in GCC High tenants, but I'm only able to hack together enough for a few functions to work.
Thanks for such an awesome tool!
The text was updated successfully, but these errors were encountered: