Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gfx rendering issues #24

Closed
simeonfelis opened this issue Sep 21, 2022 · 3 comments
Closed

gfx rendering issues #24

simeonfelis opened this issue Sep 21, 2022 · 3 comments

Comments

@simeonfelis
Copy link

Using SAM54XPlained and a ST7789S display via 4-wire SPI
Compiler XC32 v1.40
GFX Library 3.10.0
Due to #22 I cannot upgrade GFX
There are actually two issues:

  • black lines on re-rendering screens
    lines on re-rendering
  • artifacts in/around circles
    artifacts in circle

Both issues happen wether alpha-blending is enabled or not in legato composer

A sample project can be found here

With the user-button on SAM54XPlained the screen toggles. After the first toggle one can see the first black in the tiny circle; after the second toggle another black line appears as depicted. After a reset when the first screen is shown no black line is shown.

The dots in and around the circle widget are always visible. It looks like a bug in the circle draw algorithm.

@simeonfelis
Copy link
Author

I just saw the gfx 3.11.1 release and retried. The issue with the black lines on re-rendering are gone. Thanks!

The remaining issue with the dots in and around the circle widget are still present, though.

@microchip-gfx
Copy link
Contributor

Best guess is that the circle artifacts are due to the use of low accuracy fixed point math when doing the trig calculations for the circles. Recommend using pre-drawn images to avoid this.

@simeonfelis
Copy link
Author

OK, I hoped I could save 200bytes flash. Every byte saved to helps avoid running into supply chain issues. Also saves kittens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants