New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing return in atcab_aes_ccm_aad_finish #335

Open

peschuster opened this issue May 24, 2023 · 0 comments

Labels

bug

peschuster commented May 24, 2023

In

cryptoauthlib/lib/crypto/atca_crypto_hw_aes_ccm.c

Lines 370 to 376 in 86b3046

    
           if (ctx == NULL) 
        
           { 
        
               status = ATCA_TRACE(ATCA_BAD_PARAM, "Null pointer"); 
        
           } 
        
           // Pad and process any incomplete aad data blocks 
        
           if (ctx->partial_aad_size > 0)

pointer 'ctx' is checked for NULL at line 370 but will be dereferenced at line 376.

I think there is a return statement missing or the condition in line 376 should be extended to cover a null pointer.

bryan-hunt added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment