calib_execute_send() passes wrong buffer to atsend() when ATCA_HAL_LEGACY_API is #defined

[davidk408]

This error only comes into play when ATCA_HAL_LEGACY_API is #defined.

In this code block of calib_execute_send() in lib/calib/calib_execution.c:

https://github.com/MicrochipTech/cryptoauthlib/blame/405d8311a203e61657597c81b23ae7a370f485d9/lib/calib/calib_execution.c#L332-L341

On line 340 it seems like temp_buf, not txdata, should be passed to atsend(). And because of that error, txlength is one too large because it got incremented before being passed.

Poor little temp_buf[] gets loaded up with data but then her trip is canceled at the last minute. :-(((

[jd-imi]

I came to the same conclusion, so I made a PR.

[github-actions]

This issue has been marked as stale - please confirm the issue still exists with the latest version of the library and update the issue if it remains