Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Http DependencyTelemetry data structure is inconsistent with .NET SDKs #533

Closed
lmolkova opened this issue Jan 18, 2018 · 4 comments · Fixed by #567
Closed

Http DependencyTelemetry data structure is inconsistent with .NET SDKs #533

lmolkova opened this issue Jan 18, 2018 · 4 comments · Fixed by #567
Assignees
Labels
Milestone

Comments

@lmolkova
Copy link
Member

Java SDK reports method and URI in custom dimensions (in .NET SDKs it's dependency name and target)
while reporting instrumented method in the name and target
image

There are other potential discrepancies (e.g. for successful outgoing http request request target reported in 'cid-v1:' )
image

Java SDK should follow telemetry data structure and be consistent with .NET SDKs.

@littleaj littleaj added this to the 2.0.1 milestone Jan 18, 2018
@littleaj littleaj added the Bug label Jan 18, 2018
@dhaval24
Copy link
Contributor

@lmolkova thank you very much for reporting the inconsistency in HTTP DependencyTelemetry datastructure. If I recall correctly both Dot Net and Java SDK share the same Bond definition which is use
e the same Bond definition which is used to generate the DependencyData data-structure so ideally this difference should not arise, I would have to double check, however let me ask you this question :

  1. As you mentioned that custom dimension in Dot Net is reported as dependency name and target so it should be like this {Dependency Name = GET, target = URL } what does target look like ? Isn't it URI ?
  2. What does Dot Net SDK show in case of successful dependency call in target field. I have no idea from where the cid-v1 is getting populated in Java.

@lmolkova
Copy link
Member Author

lmolkova commented Jan 19, 2018

@dhaval24

As per Dependency Collector code in .NET (e.g. here and here)

Name = method + aboslute path
Target = host

Example

image

@lmolkova
Copy link
Member Author

Update: there might be different behavior for 'target' in case of same i-key and multiple i-keys, but I'm not aware of the details

@dhaval24
Copy link
Contributor

@lmolkova #567 should fix this.

@dhaval24 dhaval24 modified the milestones: future, 2.0.2 Mar 4, 2018
@ghost ghost locked as resolved and limited conversation to collaborators Jul 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants