Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Published POM for 2.0.0 is invalid #581

Closed
lhotari opened this issue Feb 28, 2018 · 12 comments
Closed

Published POM for 2.0.0 is invalid #581

lhotari opened this issue Feb 28, 2018 · 12 comments
Labels

Comments

@lhotari
Copy link

lhotari commented Feb 28, 2018

Resolving from jcenter gives this error:

> Could not resolve com.microsoft.azure:applicationinsights-core:2.0.0.
      > Could not get resource 'https://jcenter.bintray.com/com/microsoft/azure/applicationinsights-core/2.0.0/applicationinsights-core-2.0.0.pom'.
         > Could not GET 'https://jcenter.bintray.com/com/microsoft/azure/applicationinsights-core/2.0.0/applicationinsights-core-2.0.0.pom'. Received status code 409 from server: Conflict

https://jcenter.bintray.com/com/microsoft/azure/applicationinsights-core/2.0.0/applicationinsights-core-2.0.0.pom shows the error message:
"The target deployment path 'com/microsoft/azure/applicationinsights-core/2.0.0/applicationinsights-core-2.0.0.pom' does not match the POM's expected path prefix 'com/microsoft/azure/core/2.0.0'. Please verify your POM content for correctness and make sure the source path is a valid Maven repository root path."

@lhotari
Copy link
Author

lhotari commented Feb 28, 2018

This problem might be related to changes made by #551 . @littleaj , could you please check?

@lhotari
Copy link
Author

lhotari commented Feb 28, 2018

The POM for 2.0.0-BETA is valid.
list of published versions in mavencentral.
2.0.0-BETA's pom has <artifactId>applicationinsights-core</artifactId>, but 2.0.0 has <artifactId>core</artifactId>

@dhaval24
Copy link
Contributor

@lhotari yes we are working on this issue for last few hours trying to patch the updated release. Somehow maven doesn't allow to override, so if ultimately we don't get permissions to do so we would release a 2.0.1 version with fixed POMs. Deepest apologies for inconvenience here.

@dhaval24 dhaval24 added the Bug label Feb 28, 2018
@lhotari
Copy link
Author

lhotari commented Feb 28, 2018

@dhaval24 Thanks for the update. Published versions are immutable in MavenCentral, so you will have to release another version to fix the POM issue.

@dhaval24
Copy link
Contributor

@lhotari Wow , this is unexpected :( Need to nail down the root cause of this (how it happened in the first place). For now we would just manually modify the generated pom matching it from the previous releases to have the right artifact - id and release a new version. Let me know if you have any other known route.

@lhotari
Copy link
Author

lhotari commented Feb 28, 2018

@dhaval24 I wonder if #551 changes broke POM creation? Is STABLE-2.0.0 the branch that was used to publish? #551 changes seem to be the only changes in gradle directory in STABLE-2.0.0 branch after 2.0.0-BETA was released. See https://github.com/Microsoft/ApplicationInsights-Java/commits/2.0.0-STABLE/gradle

@lhotari
Copy link
Author

lhotari commented Feb 28, 2018

The artifactId for the pom used the archivesBaseName value (gradle docs) before making #551 changes. @dhaval24 do you need help in fixing the issue with the Gradle build?

@dhaval24
Copy link
Contributor

@lhotari yes 2.0.0-STABLE is the branch that was used to publish. If you can have some help would be great. What is the fix you think we need here? Currently I am preparing the build but had to manually modify the pom names and artifactIds. Should this work atleast for the release this time. Build ofcourse we need to fix.

@lhotari
Copy link
Author

lhotari commented Feb 28, 2018

@dhaval24 I created PR #582 to fix the issue and to improve pom.xml customization.

@dhaval24
Copy link
Contributor

@lhotari we just made a 2.0.1 release for fixing this issue. Could you see the pom? Sorry for all the inconvenience.

@lhotari
Copy link
Author

lhotari commented Feb 28, 2018

@dhaval24 thanks. yes, http://repo1.maven.org/maven2/com/microsoft/azure/applicationinsights-core/2.0.1/applicationinsights-core-2.0.1.pom looks ok. btw. I pushed another commit to the PR to make the pom.xml look similar so that the licence is added after the xml declaration row.

@dhaval24
Copy link
Contributor

@lhotari thank you very much. I am closing down this issue as the patched version is already out on maven central and is downloadable via gradle and maven. Thank you very much for turning up and providing your assistance in real time here.

@littleaj littleaj mentioned this issue Mar 6, 2018
2 tasks
@ghost ghost locked as resolved and limited conversation to collaborators Jul 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants