Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update InternalAgentLogger with option to write to file #752

Closed
littleaj opened this issue Sep 27, 2018 · 4 comments · Fixed by #763
Closed

Update InternalAgentLogger with option to write to file #752

littleaj opened this issue Sep 27, 2018 · 4 comments · Fixed by #763
Assignees
Milestone

Comments

@littleaj
Copy link
Contributor

This will make this a more consistent experience when configuring the SDK and the agent. SDK allows logging to CONSOLE or FILE, but the agent only prints to stdout.

Solution
Add the functionality to the agent logger, sharing as much code as possible with core.

@littleaj littleaj added this to the 2.2.1 milestone Sep 27, 2018
@littleaj littleaj self-assigned this Sep 27, 2018
@dhaval24
Copy link
Contributor

dhaval24 commented Sep 29, 2018

@littleaj and @grlima I would rather propose SLF4J as a permanent solution. @littleaj if you wish, I can experiment on SLF4J in parallel, as I am sure it would be a longer fix and we need this to have rather sooner. So I am fine, if we get the internal logger file implementation for now.

@grlima
Copy link
Contributor

grlima commented Oct 1, 2018

@dhaval24 - SLF4J makes sense to me as well. Let's consolidate all SDK logging around SLF4J.

@dhaval24
Copy link
Contributor

dhaval24 commented Oct 2, 2018

@grlima great! Let's do that. @littleaj as we discussed, my understanding is that you wanna take a stab at this. Correct? Please feel free to take over if you would like, or alternatively let me know. I will plan some evenings / weekends for it if needed.

@dhaval24 dhaval24 changed the title Update InternalAgentLogger with option to write to file Migrate SDK Logging to SLF4J Oct 2, 2018
@dhaval24
Copy link
Contributor

dhaval24 commented Oct 2, 2018

@littleaj I have renamed this, as we all are on same page for SLF4J work. I am also linking the past feature request. #309

@littleaj littleaj changed the title Migrate SDK Logging to SLF4J Update InternalAgentLogger with option to write to file Oct 2, 2018
@ghost ghost locked as resolved and limited conversation to collaborators Jul 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants