Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing URL generation from file path. #287

Merged
merged 1 commit into from
Jul 11, 2016
Merged

Conversation

tfoel
Copy link

@tfoel tfoel commented Jul 1, 2016

Appending 'file:/' at the start of a file path works only under windows, where paths start with the drive letter (-> file:/c:/...).
On Unix, paths start with /, resulting in a URL like file://var/lib/... - this is then interpreted as a file on the host 'var', in directory 'lib/...'

This fix utilizes Java to source the URL for a file, instead of crafting it manually.

Appending 'file:/' at the start of a file path work only under windows, where paths start with the drive letter (-> file:/c:/...).
On Unix, paths start with /, resulting in a URL like file://var/lib/... - this is then interpreted as a file on the host 'var', in directory 'lib/...'

This fix utilizes Java to source the URL for a file, instead of crafting it manually.
@msftclas
Copy link

msftclas commented Jul 1, 2016

Hi @SFThomas, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@msftclas
Copy link

msftclas commented Jul 1, 2016

@SFThomas, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

@OriYosefiMSFT OriYosefiMSFT merged commit 784a713 into microsoft:master Jul 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants