Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix theme menu state on mac #1280

Merged
merged 6 commits into from
Feb 1, 2019
Merged

Fix theme menu state on mac #1280

merged 6 commits into from
Feb 1, 2019

Conversation

a-b-r-o-w-n
Copy link
Contributor

@a-b-r-o-w-n a-b-r-o-w-n commented Feb 1, 2019 •
edited
Loading

closes #1239

On a mac, the radio type UI is the exact same as checkbox type, but functions correctly. This has not effect on Windows or Linux.

@a-b-r-o-w-n a-b-r-o-w-n added the 4.3 label Feb 1, 2019
@coveralls
Copy link

coveralls commented Feb 1, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 1967

  • 3 of 5 (60.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 50.303%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/app/main/src/main.ts 0 2 0.0%
Totals Coverage Status
Change from base Build 1966: 0.03%
Covered Lines: 4508
Relevant Lines: 8352
💛 - Coveralls

tonyanziano
tonyanziano previously approved these changes Feb 1, 2019
View reviewed changes
Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@a-b-r-o-w-n a-b-r-o-w-n merged commit 45124e2 into microsoft:master Feb 1, 2019
@a-b-r-o-w-n a-b-r-o-w-n deleted the fix-theme-menu branch February 1, 2019 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyanziano tonyanziano tonyanziano approved these changes

@compulim compulim Awaiting requested review from compulim

@corinagum corinagum Awaiting requested review from corinagum

@cwhitten cwhitten Awaiting requested review from cwhitten

@justinwilaby justinwilaby Awaiting requested review from justinwilaby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Currently selected Theme does not appear in Menu like it should
3 participants
@a-b-r-o-w-n @coveralls @tonyanziano