Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new sendTypingIndicator action dispatcher #2157

Closed
compulim opened this issue Jul 8, 2019 · 3 comments · Fixed by #2413
Closed

Add new sendTypingIndicator action dispatcher #2157

compulim opened this issue Jul 8, 2019 · 3 comments · Fixed by #2413
Assignees
@compulim
Labels
p1 Painful if we don't fix, won't block releasing

Comments

@compulim
Copy link
Contributor

compulim commented Jul 8, 2019

Feature Request

Is your feature request related to a problem? Please describe.

No.

Describe the suggestion or request in detail

Today, we have multiple send actions:

  • sendEvent
  • sendFiles
  • sendMessage

But we don't have sendTypingIndicator, we should add one.

But unfortunately, we already used BasicWebChat.props.sendTypingIndicator as a true/false value to indicate if we should send typing indicator to the bot.

We need a better plan to rename it to shouldSendTypingIndicator or find a better way for the action dispatcher.

Describe alternatives you have considered

Additional context

[Enhancement]
@corinagum corinagum added 4.6 p1 Painful if we don't fix, won't block releasing front-burner labels Jul 8, 2019
@tdurnford tdurnford self-assigned this Aug 5, 2019
@tdurnford
Copy link
Contributor

tdurnford commented Sep 13, 2019 •
edited
Loading

Right now, it looks like we are using the postActivity action to send a typing indicator to the bot. We could add one called postTypingActivity or sendTypingActivity. @corinagum @compulim thoughts?

@tdurnford
Copy link
Contributor

I think we settled on using emitTypingIndicator. Reassigning to @compulim since this falls in line with his work on migrating to React Hooks.

@tdurnford tdurnford assigned compulim and unassigned tdurnford Sep 13, 2019
@cwhitten
Copy link
Member

addressed in #2364

@compulim compulim mentioned this issue Sep 21, 2019
Merged
1 task
@compulim compulim mentioned this issue Oct 25, 2019
Closed
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@compulim compulim

Labels
p1 Painful if we don't fix, won't block releasing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add new emitTypingIndicator action compulim/BotFramework-WebChat
4 participants
@cwhitten @compulim @corinagum @tdurnford